Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp3278740imm; Sun, 16 Sep 2018 14:12:14 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdbi4QuXjR+PKY3TLhDv/32DzsN4lLcBXLzlZNfDbReM67BWRy7VcPqkiLGSq4bEfAO8lx9T X-Received: by 2002:a63:a053:: with SMTP id u19-v6mr21041117pgn.394.1537132334136; Sun, 16 Sep 2018 14:12:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537132334; cv=none; d=google.com; s=arc-20160816; b=Wnw4AiHREvGistb+CVAuYj+VwJZIJwdY+zUFgI58GGbT+QeWPQ/ILZSE0ZZBOjXVIC Vj6ZAjKsoO1kXYzKoPG2tWAhHLjtS7fFdQ3i6gd3aLTpDU9fdwkqoEcdSJyaPk7nb1tG jIdvDHyVvmKIzq70icY/9Ss/OaLh+V6Y4qz4kPCXkzgK2WscO6JfNxqqRKvYqV4Pmu/7 TZebJz7PlFD9AKK85maGbTXrwox4K38lOrlz7ZwTHscZfoq0CmIivdEbUZpJBeEGovao nBcdR/V5AW2AE7TAMJCt0t6avjALO/cWz/Zt4mvwIqywsgyhgacBwGavf60V7Vtg9tN7 Bplw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=ywX6En6M4Nqa3xCOyewph4LSob2/f+CtYtPrPgFe27A=; b=i5YtB1IZZI+CfWaHl2m4BadohVzvue/FSHUI1HzUxunlzoN1umjQqUgkLxRU88AM6r UEwBVgi1KpQaBysW528TPengFVJ9c30rpbEYp3g+n4xxEucVOkskb19HlQXC9aFWdebk 6CikIjT4HkK/pCnxO6zQckSpWeBtMSxtZ7P8WGy7fS1977ZWm0BJbA7FOSehqDHbbRyC oR3lSiDwkh0Z6vdokmLGqd4/F/SMf++1Ob3rCPqLoYmWS5yJq6FkpVqv6AX+1Bbk4Gi2 m3QEqys2KJZ/ypuoLlFXf3cIt/Y4wMwIwfR8NLRYPw1NNdBNRKbgdUlAHV+UMrnE3uZw qENA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j15-v6si12799462pfn.366.2018.09.16.14.11.21; Sun, 16 Sep 2018 14:12:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728390AbeIQCfc (ORCPT + 99 others); Sun, 16 Sep 2018 22:35:32 -0400 Received: from mleia.com ([178.79.152.223]:43670 "EHLO mail.mleia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728168AbeIQCfc (ORCPT ); Sun, 16 Sep 2018 22:35:32 -0400 Received: from mail.mleia.com (localhost [127.0.0.1]) by mail.mleia.com (Postfix) with ESMTP id 81604417702; Sun, 16 Sep 2018 22:11:15 +0100 (BST) Subject: Re: [PATCH] net: ethernet: remove redundant null pointer check before of_node_put To: zhong jiang , davem@davemloft.net Cc: fugang.duan@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1537103622-63482-1-git-send-email-zhongjiang@huawei.com> From: Vladimir Zapolskiy Message-ID: Date: Mon, 17 Sep 2018 00:11:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1537103622-63482-1-git-send-email-zhongjiang@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-49551924 X-CRM114-CacheID: sfid-20180916_221115_549087_62D06D38 X-CRM114-Status: UNSURE ( 5.78 ) X-CRM114-Notice: Please train this message. Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/16/2018 04:13 PM, zhong jiang wrote: > of_node_put has taken the null pinter check into account. So it is > safe to remove the duplicated check before of_node_put. > > Signed-off-by: zhong jiang typo in the commit message, s/pinter/pointer/ Other than that please feel free to add my Reviewed-by: Vladimir Zapolskiy