Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp3549638imm; Sun, 16 Sep 2018 21:56:55 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYjXDErEZPc+OJ0vAT9If8WSpWRfRu++akHNV0FzIUQjPE5MR2Mu8drgK0rpeSeK01XKTd3 X-Received: by 2002:a62:b604:: with SMTP id j4-v6mr23940330pff.199.1537160215466; Sun, 16 Sep 2018 21:56:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537160215; cv=none; d=google.com; s=arc-20160816; b=PQGH4MJs+VCCLGTyM+2FcC2QBJ22RBZt1iKWwn75uwv3mD4QvCcmv6jcIciQnVE5Fc 7Yo8iYW+Gk+C7sm4zbSc/LoxIgLpJfutVkRBcMNXJNbA1eunt2zIYhFKYQnhbo4hSWq1 14MJ7npSKrGvT6Hp8keeMtZeJSUULlVt7NUpoIQnxECmkHjQc9zP14KnlO/c4rE+XUt4 BIy1PJqgSLPb+r9M5dOJa+4RMPhL+2vcCZgzKY3TPfkKx5QHP9B9SYchSZ8wNCieYBNR PAOYpRUtdsPY8Fr5eC6aHy5epNwXaLj2DCLEjT4eFWS/HKP9gM/MTW/qtngeEZYSjD7O ufqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=AZqTaeTkA4IuMqx9kGrBL+WmzHB/SpZRlJQF/WxkPBg=; b=GW9xMhTwXShMf65ap7s4nC8/g+iETOqODnfewHGz/FkNASMpicDIpA6Y5SFEoOeGVg K8L8SdCUZAxgj9823Q0YLYllr8a4S/svTXo3bcCpr92qJ0wrbMo58+Nwk7zn8cupy+9+ vE8cfKltyWUPV7pXC6MRnWGCFmYBXNBXO/IPUzPgkNszZPvEEhtkTX7IQ+cF9HP+8LvB wGdqsQOj3R75+HgXPAUVd6fUImtiWfa7ZS54Ahb+z+q7OPxXo3V2uLno9fHgz2Smqys1 OnFYNEn5pY6W56dGRRTsr/RAq8fqCkdRZNN8N4pnl3rn3OX8Utt8qM9Rc2eR2dFbDW+O yZMg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u5-v6si14625069pgc.459.2018.09.16.21.56.40; Sun, 16 Sep 2018 21:56:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728454AbeIQKV5 (ORCPT + 99 others); Mon, 17 Sep 2018 06:21:57 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33938 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727726AbeIQKV5 (ORCPT ); Mon, 17 Sep 2018 06:21:57 -0400 Received: from localhost (ip-213-127-77-73.ip.prioritytelecom.net [213.127.77.73]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 8A3F0BE0; Mon, 17 Sep 2018 04:56:16 +0000 (UTC) Date: Mon, 17 Sep 2018 06:56:13 +0200 From: Greg KH To: kys@microsoft.com Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com, sthemmin@microsoft.com, Michael.H.Kelley@microsoft.com, vkuznets@redhat.com Subject: Re: [PATCH 2/2] tools: hv: fcopy: set 'error' in case an unknown operation was requested Message-ID: <20180917045613.GA25435@kroah.com> References: <20180917041352.11402-1-kys@linuxonhyperv.com> <20180917041455.11455-1-kys@linuxonhyperv.com> <20180917041455.11455-2-kys@linuxonhyperv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180917041455.11455-2-kys@linuxonhyperv.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 17, 2018 at 04:14:55AM +0000, kys@linuxonhyperv.com wrote: > From: Vitaly Kuznetsov > > 'error' variable is left uninitialized in case we see an unknown operation. > As we don't immediately return and proceed to pwrite() we need to set it > to something, HV_E_FAIL sounds good enough. > > Signed-off-by: Vitaly Kuznetsov > Signed-off-by: K. Y. Srinivasan > --- > tools/hv/hv_fcopy_daemon.c | 1 + > 1 file changed, 1 insertion(+) No need to backport for stable?