Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp3722112imm; Mon, 17 Sep 2018 01:59:41 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYnv8IRqguIRlvvpKZzVnt0Yv6H9TCMPe+w02WJNRW57qztHEPO++TjGWCZwaDbNxe6HNOp X-Received: by 2002:a62:3ac8:: with SMTP id v69-v6mr24825672pfj.164.1537174780982; Mon, 17 Sep 2018 01:59:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537174780; cv=none; d=google.com; s=arc-20160816; b=iaKJTjrAzYN5ErGjHfUGUhA8wbDArp+VxUunMOFaZVGVAiSQnAq6lorQH62QrNsvi9 6wTE5jy2Uj9S4qwEEG6Uuo8KFH9aKc8QqxJ0NXSwXhiYUbuzEULCW0W6f6qQI26USoBO BR33aSW7QahiAk+nCV2pR73lu6uYTxxtxKmHfDvi531/zfCo5Bn8pi97geKyYf/cJgnJ zh8OvuqKQMo6GxpsOr7HN0ZbKNRpKmqc+ffO+p8vud+ahlSDvlQiQ3JhqVBdB79ZcXVD k+s/QXGa0AFd2B93kbW3f76Y0UQQ23C18boNysBeyZWXBr3jnfSMcHLMUrS8vX3hKFVu GwwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=QkTxYdgDOlRq2zyG+S+QLDOVfmhSN3dXupFwDLvcAKw=; b=wG5gHz9ZkiuouVm5uxbIkh1BLEAkVOQWhblHbPGoWwbOHmGNvDSTNf8dl7XJLhWMW4 kDAUg4q6wY/q9/zVc2kxVyplTLTb0mnMEIyqjMz9hcih+gfj2PY58YGr3bc/tNxVecI3 v++CTXNxtY4yUHxGrhTDoJJrXtmX6fR4csEHDpPQQ774RxSkKzkb9o0YuRBRk5t4/fK+ a+T7nMkYQVVdvjLJwodjqtjVbO8B4fDPIVmqYAwWvd/YiVWD9g94YZd5XrhFUHvowoNe S8B8t2xBi/+DDr8raq87GRu0GUyLy0RmpCf1ZPllU7jnEOT1nCqrpzLvJ0/KFybl1uhG S0Lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=X0OF+EkB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y9-v6si15178669pgs.521.2018.09.17.01.59.25; Mon, 17 Sep 2018 01:59:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=X0OF+EkB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727460AbeIQOZZ (ORCPT + 99 others); Mon, 17 Sep 2018 10:25:25 -0400 Received: from merlin.infradead.org ([205.233.59.134]:32788 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727166AbeIQOZY (ORCPT ); Mon, 17 Sep 2018 10:25:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=QkTxYdgDOlRq2zyG+S+QLDOVfmhSN3dXupFwDLvcAKw=; b=X0OF+EkBJPNd38RCKBXMeguNV xl+ep8UdJ6msAMHL6rQFkHSONdMdvDab+gn61vxaSn2tU2fdTPHO31V/CH6V4tsXvxvVtdCuWIKm3 EHDbqpFl9SH+47s94FdRZGXbQWMVbEueyQqfVm9CNsqe2vccxnNNUuyhiKlwoK+ao1mHaaptm2B6g rV9e98Xgmwx+SJJOGXQZ92enF1hxHJ6Bx2PFJAZ4WtFagk5vaYlT5P/as9+LKaebdefXaLbP9YbhN Ug3y4bXw4EFHlv4HPZFnt3QDUwzjea467UmGI6DXpYbA4lWykWfkehpW+KiRNfSAaCs6XlPDIUu3J HZ7Aflqqg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1g1pMp-0001sZ-9b; Mon, 17 Sep 2018 08:58:51 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id A2CC12058A23D; Mon, 17 Sep 2018 10:58:48 +0200 (CEST) Date: Mon, 17 Sep 2018 10:58:48 +0200 From: Peter Zijlstra To: Reinette Chatre Cc: tglx@linutronix.de, fenghua.yu@intel.com, tony.luck@intel.com, mingo@redhat.com, acme@kernel.org, gavin.hindman@intel.com, jithu.joseph@intel.com, dave.hansen@intel.com, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3 5/6] x86/intel_rdt: Use perf infrastructure for measurements Message-ID: <20180917085848.GQ24124@hirez.programming.kicks-ass.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 11, 2018 at 10:14:36AM -0700, Reinette Chatre wrote: > +static int measure_l2_residency(void *_plr) > +{ > + measure_residency_fn(&perf_miss_attr, &perf_hit_attr, plr, &counts); > +} > + > +static int measure_l3_residency(void *_plr) > +{ > + measure_residency_fn(&perf_miss_attr, &perf_hit_attr, plr, &counts); Not sure it's important, but both sites loose the error return.