Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [dm-devel] [PATCH] dm raid: Remove bogus const from
 decipher_sync_action() return type
To:     Geert Uytterhoeven <geert@linux-m68k.org>,
        Mike Snitzer <snitzer@redhat.com>,
        Alasdair Kergon <agk@redhat.com>
Cc:     dm-devel@redhat.com, linux-kernel@vger.kernel.org,
        Arnd Bergmann <arnd@arndb.de>
References: <20180917080234.10909-1-geert@linux-m68k.org>
From:   Heinz Mauelshagen <heinzm@redhat.com>
Message-ID: <3623d6d7-a94f-2a35-83a9-dd475136d936@redhat.com>
Date:   Mon, 17 Sep 2018 13:58:31 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180917080234.10909-1-geert@linux-m68k.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-MW
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Yes, the compiler is right to warn about a meaningless 'const' return by 
value.

Acked-by: Heinz Mauelshagen <heinzm@redhat.com>


On 09/17/2018 10:02 AM, Geert Uytterhoeven wrote:
> With gcc-4.1.2:
>
>      drivers/md/dm-raid.c:3357: warning: type qualifiers ignored on function return type
>
> Remove the "const" keyword to fix this.
>
> Fixes: 36a240a706d43383 ("dm raid: fix RAID leg rebuild errors")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>   drivers/md/dm-raid.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
> index 5ba067fa0c729bc8..c44925e4e4813d24 100644
> --- a/drivers/md/dm-raid.c
> +++ b/drivers/md/dm-raid.c
> @@ -3353,7 +3353,7 @@ static const char *sync_str(enum sync_state state)
>   };
>   
>   /* Return enum sync_state for @mddev derived from @recovery flags */
> -static const enum sync_state decipher_sync_action(struct mddev *mddev, unsigned long recovery)
> +static enum sync_state decipher_sync_action(struct mddev *mddev, unsigned long recovery)
>   {
>   	if (test_bit(MD_RECOVERY_FROZEN, &recovery))
>   		return st_frozen;