Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4037178imm; Mon, 17 Sep 2018 07:16:16 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZsZ79wPP68i2xV2E9rSHCqI/+8SxZEb9lXU+XuIT7mcc4nvmIAwcU4KnPqTCb5NPpBnxvW X-Received: by 2002:a63:7c50:: with SMTP id l16-v6mr23684972pgn.311.1537193776807; Mon, 17 Sep 2018 07:16:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537193776; cv=none; d=google.com; s=arc-20160816; b=vWozK2ZAabxP588wwkJpHm+IvoEigl+BORRL1kAiIVL33IFQhNeATMnsaYoxuGpzsv 1/byTm18W362omv9wRad333LBEkWjIhSb+VNT54ncsjwAU4sEGARCQE2dR6L9ECzBGCK /eB/2hEDzByhgFhsxN0GmNNxkoGqJKwjlElQqjW5VTx9N8kejGcflFWdWkoTkWr/kYHS 78wyt1Xtst1A69mdNhfMz12HuKXkAQKxE0BpxjNuCXQAe5AFySg/LdZh28ZBp9PMi48b BBqdkUMNhBBJN95V84oS5yS8tohls/POfp/baXj3MKf2/rCl6rTaemfUaaoMXJRLQUJD bUPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=8LghUUWOmXufEch7kpy+DkWJJ2SdbF/gHhXRRgHQH8o=; b=uRNZ4J7as7FIcKdX0lCxEZVLC8UhWI8melEafvo48BnGdLqp7HFaPHb4t7+BGZAbJt kGT1ZoMwEYB/4wRG5QXmBuzgLckpirYkoH5Vc0Jx7pK7uU1B7iwS5m9H6V74nVxbvvRO UX4fvCbl8dgLhLBFxtQY7+59iZi+tmbTvoeHCh5dMTXLxG2S6+UkZEqdU3s3gF9if8Uz KodHPJmPV+dl2wEEFQ1+HEAw4pbaqFUwiY8sVlqMjnfC+1VbxKwwLTZg26kKs20tzZk4 mc2B5zOV36Ng9wlErpom7bK72upZDTEEtT+ihD90a/47H3iRTRrCQe2EriKBHCRPqo4I sdxg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 44-v6si16418294plc.409.2018.09.17.07.15.55; Mon, 17 Sep 2018 07:16:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728764AbeIQTnK (ORCPT + 99 others); Mon, 17 Sep 2018 15:43:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:59068 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727021AbeIQTnK (ORCPT ); Mon, 17 Sep 2018 15:43:10 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 0C8C6B041; Mon, 17 Sep 2018 14:15:36 +0000 (UTC) Date: Mon, 17 Sep 2018 07:15:28 -0700 From: Davidlohr Bueso To: Waiman Long Cc: Alexander Viro , Jan Kara , Jeff Layton , "J. Bruce Fields" , Tejun Heo , Christoph Lameter , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Andi Kleen , Dave Chinner , Boqun Feng Subject: Re: [PATCH v9 3/5] vfs: Use dlock list for superblock's inode list Message-ID: <20180917141528.GI3902@linux-r8p5> References: <1536780532-4092-1-git-send-email-longman@redhat.com> <1536780532-4092-4-git-send-email-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1536780532-4092-4-git-send-email-longman@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 12 Sep 2018, Waiman Long wrote: >@@ -927,8 +921,6 @@ struct inode *new_inode(struct super_block *sb) > { > struct inode *inode; > >- spin_lock_prefetch(&sb->s_inode_list_lock); I think we can get rid of the spin_lock_prefetch call altogether as this is the only user left afaict.