Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4075316imm; Mon, 17 Sep 2018 07:50:38 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYRMifepdG0sLisQncNIMwj0WOROrTESb2yoZpsQbF0no2WnozsgrpEgFQKMpyfd4ZMCRti X-Received: by 2002:a62:9bc9:: with SMTP id e70-v6mr25816195pfk.95.1537195838141; Mon, 17 Sep 2018 07:50:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537195838; cv=none; d=google.com; s=arc-20160816; b=B5AxHi52IKMVXj8b3XJrR4LImrBTESLW4Bbd0sa3/8QCZkK4PBlFth2JVquWXhHqJ7 HBVcO3Pag6yJP6hmfVZ2MaAp7nCrxV7MbIEqyjg0QsCwCOBldryaNHzGCj+LDRiGowAM 8NJp3EKUXISLkCA/p72l070GNSdzmtyI5THIzKsE6lPuRHTM0lf6SflSRf8b96o2C0az yWHXYL1N7veDkuGO2vzAC+M/Vihd19Yide3cRYvcMTScDoWQ2xQgtMkdOp9Cc3vgy51q chZe90wsMeF3o7TZKtIdKxaOAtIK8mb6KIpEBtQHMkkGt2sBfnZhGmkfpMWt6sZXZ3Ir PzQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=YTyf024e26CLJHIJHtTAiq38skBnTjzlQQPyT3MDLFU=; b=Fqh/rNi8qrO5HeaN4YyWrNhNeOrOY26mnlqJaG7FBA41QAwhV7Kb1Z0Rr7XDNM75ek 7npprwcxJFldKGu4U+kWYu7GE+Z423wCaHG6kc/xbUSqfvCqkDE1gJH8HKUZSz92fdhY 6K6n9UyDB/mFR57j8k3Y/bqABKZ0uLun+/dXZIi0Y5o9tul5P2iZ85mC6v00NQDtB++s 9FPCVNxHaQX9BlsYn2CxoxVjf9Wk675R3LshEA3GK8hz7+p0sPKjd2CX5F/hzLLvo89U jxTw9kvloeqejtKVwKncyhUti0ziKF5a6Nvn1NziG73hO1Xz66RixFntuAJ5IGhbQh3d SViQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3-v6si15892860pll.509.2018.09.17.07.50.20; Mon, 17 Sep 2018 07:50:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728779AbeIQURw (ORCPT + 99 others); Mon, 17 Sep 2018 16:17:52 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:45514 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727052AbeIQURw (ORCPT ); Mon, 17 Sep 2018 16:17:52 -0400 Received: from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net [74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 757D61449F963; Mon, 17 Sep 2018 07:50:12 -0700 (PDT) Date: Mon, 17 Sep 2018 07:49:52 -0700 (PDT) Message-Id: <20180917.074952.1048947634651253553.davem@davemloft.net> To: clabbe@baylibre.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: ethernet: ti: add missing GENERIC_ALLOCATOR dependency From: David Miller In-Reply-To: <1536924007-2440-1-git-send-email-clabbe@baylibre.com> References: <1536924007-2440-1-git-send-email-clabbe@baylibre.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 17 Sep 2018 07:50:12 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Corentin Labbe Date: Fri, 14 Sep 2018 11:20:07 +0000 > This patch mades TI_DAVINCI_CPDMA select GENERIC_ALLOCATOR. > without that, the following sparc64 build failure happen > > drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_check_free_tx_desc': > (.text+0x278): undefined reference to `gen_pool_avail' > drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_chan_submit': > (.text+0x340): undefined reference to `gen_pool_alloc' > (.text+0x5c4): undefined reference to `gen_pool_free' > drivers/net/ethernet/ti/davinci_cpdma.o: In function `__cpdma_chan_free': > davinci_cpdma.c:(.text+0x64c): undefined reference to `gen_pool_free' > drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_desc_pool_destroy.isra.6': > davinci_cpdma.c:(.text+0x17ac): undefined reference to `gen_pool_size' > davinci_cpdma.c:(.text+0x17b8): undefined reference to `gen_pool_avail' > davinci_cpdma.c:(.text+0x1824): undefined reference to `gen_pool_size' > davinci_cpdma.c:(.text+0x1830): undefined reference to `gen_pool_avail' > drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_ctlr_create': > (.text+0x19f8): undefined reference to `devm_gen_pool_create' > (.text+0x1a90): undefined reference to `gen_pool_add_virt' > Makefile:1011: recipe for target 'vmlinux' failed > > Signed-off-by: Corentin Labbe Applied.