Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4113131imm; Mon, 17 Sep 2018 08:22:37 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZr9h8TksWIAzpyZdLewjEwB8TFq+lsdRVIOxVbX1cyAUh5q0gw8qqcchkNgNfEBHNvDej1 X-Received: by 2002:a63:9c19:: with SMTP id f25-v6mr24323277pge.447.1537197757129; Mon, 17 Sep 2018 08:22:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537197757; cv=none; d=google.com; s=arc-20160816; b=XTivhQs0QnAfIigaT4INc/lJrL/sI1Z8f2wxLKIEPV8SpFQy1LGuQlGDcjrCDSBXzs s5fwZoOZqPqdwUdcnJebFf6kzDn16h5GIR7Y1rEL/cJ7Yoj7kSvEcp3wJZitScTeigfv 4XzIJskMcoxfXrX7taQXddPtFak4H/gA68kKmh2r+HqYQsmMJpx2g0dmoLdIR6m855o8 IhFcpVL2F5udqRG5UYkXlTsZFXLQiCO9Zf4QwpiutM77J3osRKsj0iwNLLfBXK19kUml J+mphpjB0h/UvGtZSN8BW14yHdGteoyjKZ5xv6wk3udYtAceeHIvF5HuYZeW54P6Uslf vHtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=5Hz0h6Fwy6pTvW9cBEg4wudrZdN/ZSv3IDsE0c3iw78=; b=QD7HOVYnnP+wyIR80QLUxty3lgRIDequo3zIuKcRnYiWs4FU4czLRIAaVylvPogfq8 41BEMNxwyK6K/98XCk9ZA+U4T64MaNFol1BbX5RmCeQHKTdnNIk9GLLJGdd1Oa6zPlkw xA6gdq1aO6QVixUrizYJs/ilo+isKec8ylDVzgvalJBTE5Zf4tYERAvOOK/dXJa5zXua +bTE8nNXoi+//96Ort9ULbubF9rKZe9V+3T3tugGuLKuWarD75/L3by8WOOgDRsr0rsB R3dZXgtql+DZvH41M11eBkDetv/sJFqu17hQO3GZWZ9n9qHLhNdllx2LIZ+OOSoNhWLz noDQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t22-v6si15745040pgj.546.2018.09.17.08.22.21; Mon, 17 Sep 2018 08:22:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729205AbeIQUsc (ORCPT + 99 others); Mon, 17 Sep 2018 16:48:32 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:46250 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727870AbeIQUsc (ORCPT ); Mon, 17 Sep 2018 16:48:32 -0400 Received: from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net [74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id BD18E144B5745; Mon, 17 Sep 2018 08:20:43 -0700 (PDT) Date: Mon, 17 Sep 2018 08:20:43 -0700 (PDT) Message-Id: <20180917.082043.2234883912051795791.davem@davemloft.net> To: zhongjiang@huawei.com Cc: fugang.duan@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ethernet: remove redundant null pointer check before of_node_put From: David Miller In-Reply-To: <1537103622-63482-1-git-send-email-zhongjiang@huawei.com> References: <1537103622-63482-1-git-send-email-zhongjiang@huawei.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 17 Sep 2018 08:20:43 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: zhong jiang Date: Sun, 16 Sep 2018 21:13:42 +0800 > of_node_put has taken the null pinter check into account. So it is > safe to remove the duplicated check before of_node_put. > > Signed-off-by: zhong jiang Applied.