Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   KY Srinivasan <kys@microsoft.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "olaf@aepfle.de" <olaf@aepfle.de>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Michael Kelley (EOSG)" <Michael.H.Kelley@microsoft.com>,
        "apw@canonical.com" <apw@canonical.com>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        vkuznets <vkuznets@redhat.com>
Subject: RE: [PATCH 2/2] tools: hv: fcopy: set 'error' in case an unknown
 operation was requested
Thread-Topic: [PATCH 2/2] tools: hv: fcopy: set 'error' in case an unknown
 operation was requested
Thread-Index: AQHUTj0kC9QAPEQ0iE6UniLG57hPj6Tz6QmAgACbuWCAAAQqAIAAD9ZA
Date:   Mon, 17 Sep 2018 15:25:21 +0000
Message-ID: <MW2PR2101MB1113B8449D633C9D12BA5A07A01E0@MW2PR2101MB1113.namprd21.prod.outlook.com>
References: <20180917041352.11402-1-kys@linuxonhyperv.com>
 <20180917041455.11455-1-kys@linuxonhyperv.com>
 <20180917041455.11455-2-kys@linuxonhyperv.com>
 <20180917045613.GA25435@kroah.com>
 <MW2PR2101MB11138F9E55814399F152859FA01E0@MW2PR2101MB1113.namprd21.prod.outlook.com>
 <20180917142828.GA31799@kroah.com>
In-Reply-To: <20180917142828.GA31799@kroah.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b08e10c-d141-4f82-6ead-08d61cb1c917
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Sep 2018 15:25:22.6708
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB0939
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Monday, September 17, 2018 7:28 AM
> To: KY Srinivasan <kys@microsoft.com>
> Cc: olaf@aepfle.de; Stephen Hemminger <sthemmin@microsoft.com>;
> jasowang@redhat.com; linux-kernel@vger.kernel.org; Michael Kelley
> (EOSG) <Michael.H.Kelley@microsoft.com>; apw@canonical.com;
> devel@linuxdriverproject.org; vkuznets <vkuznets@redhat.com>
> Subject: Re: [PATCH 2/2] tools: hv: fcopy: set 'error' in case an unknown
> operation was requested
>=20
> On Mon, Sep 17, 2018 at 02:16:48PM +0000, KY Srinivasan wrote:
> >
> >
> > > -----Original Message-----
> > > From: Greg KH <gregkh@linuxfoundation.org>
> > > Sent: Sunday, September 16, 2018 9:56 PM
> > > To: KY Srinivasan <kys@microsoft.com>
> > > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org;
> > > olaf@aepfle.de; apw@canonical.com; jasowang@redhat.com; Stephen
> > > Hemminger <sthemmin@microsoft.com>; Michael Kelley (EOSG)
> > > <Michael.H.Kelley@microsoft.com>; vkuznets <vkuznets@redhat.com>
> > > Subject: Re: [PATCH 2/2] tools: hv: fcopy: set 'error' in case an unk=
nown
> > > operation was requested
> > >
> > > On Mon, Sep 17, 2018 at 04:14:55AM +0000, kys@linuxonhyperv.com
> wrote:
> > > > From: Vitaly Kuznetsov <vkuznets@redhat.com>
> > > >
> > > > 'error' variable is left uninitialized in case we see an unknown op=
eration.
> > > > As we don't immediately return and proceed to pwrite() we need to s=
et
> it
> > > > to something, HV_E_FAIL sounds good enough.
> > > >
> > > > Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> > > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > > > ---
> > > >  tools/hv/hv_fcopy_daemon.c | 1 +
> > > >  1 file changed, 1 insertion(+)
> > >
> > > No need to backport for stable?
> > Thanks for pointing this out. Should I resubmit with the stable tag?
>=20
> I can do it... :)
Thank you!

K. Y