Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH V3 5/6] x86/intel_rdt: Use perf infrastructure for
 measurements
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     tglx@linutronix.de, fenghua.yu@intel.com, tony.luck@intel.com,
        mingo@redhat.com, acme@kernel.org, gavin.hindman@intel.com,
        jithu.joseph@intel.com, dave.hansen@intel.com, hpa@zytor.com,
        x86@kernel.org, linux-kernel@vger.kernel.org
References: <cover.1536685533.git.reinette.chatre@intel.com>
 <e49f32d40c53839c31e1376f11059539afd08f23.1536685533.git.reinette.chatre@intel.com>
 <20180917085848.GQ24124@hirez.programming.kicks-ass.net>
From:   Reinette Chatre <reinette.chatre@intel.com>
Message-ID: <daeb5e60-de3e-4f08-0e06-25ab83bbe2fe@intel.com>
Date:   Mon, 17 Sep 2018 09:54:14 -0700
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180917085848.GQ24124@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Peter,

On 9/17/2018 1:58 AM, Peter Zijlstra wrote:
> On Tue, Sep 11, 2018 at 10:14:36AM -0700, Reinette Chatre wrote:
>> +static int measure_l2_residency(void *_plr)
>> +{
> 
>> +	measure_residency_fn(&perf_miss_attr, &perf_hit_attr, plr, &counts);
> 
>> +}
>> +
>> +static int measure_l3_residency(void *_plr)
>> +{
> 
>> +	measure_residency_fn(&perf_miss_attr, &perf_hit_attr, plr, &counts);
> 
> Not sure it's important, but both sites loose the error return.
> 

measure_l2_residency() as well as measure_l3_residency() are thread
functions so this error does not propagate directly to the caller.

Even so, by not exiting the thread here if measure_residency_fn() fails
the tracepoints will be written with zeroes. If we exited here the
tracepoints will not be written and the trace buffer will be empty when
the user searches for the measurement data. Do you perhaps have an
inclination to which a user would prefer?

Reinette