Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <1537201883-2518-1-git-send-email-zhongjiang@huawei.com>
References: <1537201883-2518-1-git-send-email-zhongjiang@huawei.com>
From:   Michael Chan <michael.chan@broadcom.com>
Date:   Mon, 17 Sep 2018 10:36:44 -0700
Message-ID: <CACKFLineQuBTUGaBLgRqSTEcVzyZaZAnzy0jOHREKdtCqmy6pQ@mail.gmail.com>
Subject: Re: [PATCH] net: bnxt: Fix a uninitialized variable warning.
To:     zhong jiang <zhongjiang@huawei.com>,
        Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Cc:     David Miller <davem@davemloft.net>,
        Netdev <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Sep 17, 2018 at 9:31 AM, zhong jiang <zhongjiang@huawei.com> wrote:
>
> Fix the following compile warning:
>
> drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c:49:5: warning: =E2=80=
=98nvm_param.dir_type=E2=80=99 may be used uninitialized in this function [=
-Wmaybe-uninitialized]
>   if (nvm_param.dir_type =3D=3D BNXT_NVM_PORT_CFG)
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/=
net/ethernet/broadcom/bnxt/bnxt_devlink.c
> index f3b9fbc..ab88217 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
> @@ -31,7 +31,7 @@ static int bnxt_hwrm_nvm_req(struct bnxt *bp, u32 param=
_id, void *msg,
>  {
>         struct hwrm_nvm_get_variable_input *req =3D msg;
>         void *data_addr =3D NULL, *buf =3D NULL;
> -       struct bnxt_dl_nvm_param nvm_param;
> +       struct bnxt_dl_nvm_param nvm_param =3D {0};
>         int bytesize, idx =3D 0, rc, i;
>         dma_addr_t data_dma_addr;
>

I think it is better to return error if there is no param_id match
after the for loop.  The for loop will initialize nvm_param if there
is param_id match.