Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4260822imm; Mon, 17 Sep 2018 10:45:35 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYTbxgM6gmFFI0H1bixmCj5PunPiriUnUOOFu/4+vGIqzBhLXgr1+IRPjFvgDCYImwO5HeX X-Received: by 2002:a63:ad07:: with SMTP id g7-v6mr24452640pgf.19.1537206335374; Mon, 17 Sep 2018 10:45:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537206335; cv=none; d=google.com; s=arc-20160816; b=pL+xFi3XYAgSfOttoTYfeXQpvg7d1ceo/5iy1ASnTCV3zMV56yyYjuVff0GtDA7Ybc i8U55NiH1N9ZK9BZ1rCgzPk8iCqy85R0NGj3CgKRF4+0czzhJJ1JI3dQiPXxbbFoow03 q1vjZ5TGiEFylNcoWRYIIhghc0Sz+6o2yrYWi1ukznXJgzfqrMajWMNxgxbNAaVE8UD0 vs1NVKrHwU+BdB198SK87KHw5YdCca9dKQJ9MzkbIERf0qsVzq9UKyyAexoBGwTodsJS VFlhFXUeAGkUWvADs+pkSPQ15TIvjJlZADn8ttRoXai2AjJ5pkiNXJRvRSfcreiefk8j c/Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=xVcJoEy+W0Hg1Jz9dPi12Pb3NxDAF6/ePAI49X9F5AI=; b=dierTFZBNvnqlmOr0r3Ex9cde1xk+644QPDsZO4pJYON3LKhTM2eLgTvjbv9gAzYlf inEMF5hlxHq/G5GrZ2FToqIXM1o1gyUQ17Jz7VwSNmlEsYlR0PftBW+AHuOIR9hz4+ez +RPmqfaA33VD1AYBbn82NB08lPOFHjZ1K3Vs3SLqQuvrryuDMoAAdv3EAgKBrWcWhzcJ GOs7GBqzhzzIJdJ8EMTAWxQGw2HujpudFwmUdvbVXuDWaSqWuSNV06Ka9baGyFuNYgQ+ QwP83Q0ToernqJYzzXzCEz9iTHtQss7pHd9oWXtNTUoYjn6QlcKotROkdw7ygBDW6RFU R86A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p1-v6si16737832pfb.280.2018.09.17.10.45.18; Mon, 17 Sep 2018 10:45:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728000AbeIQXMO (ORCPT + 99 others); Mon, 17 Sep 2018 19:12:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42926 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726865AbeIQXMO (ORCPT ); Mon, 17 Sep 2018 19:12:14 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F14B388318; Mon, 17 Sep 2018 17:43:51 +0000 (UTC) Received: from whitewolf.lyude.net.com (ovpn-121-187.rdu2.redhat.com [10.10.121.187]) by smtp.corp.redhat.com (Postfix) with ESMTP id AD62217BBF; Mon, 17 Sep 2018 17:43:47 +0000 (UTC) From: Lyude Paul To: dri-devel@lists.freedesktop.org Cc: Gustavo Padovan , Maarten Lankhorst , Sean Paul , David Airlie , linux-kernel@vger.kernel.org Subject: [PATCH] drm/probe_helper: Don't bother probing when connectors are forced off Date: Mon, 17 Sep 2018 13:43:44 -0400 Message-Id: <20180917174344.22011-1-lyude@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 17 Sep 2018 17:43:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Userspace asked them to be forced off, so why would we care about what a probe tells us? Signed-off-by: Lyude Paul --- drivers/gpu/drm/drm_probe_helper.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c index a1bb157bfdfa..56d2b5dd1f58 100644 --- a/drivers/gpu/drm/drm_probe_helper.c +++ b/drivers/gpu/drm/drm_probe_helper.c @@ -269,7 +269,9 @@ drm_helper_probe_detect_ctx(struct drm_connector *connector, bool force) retry: ret = drm_modeset_lock(&connector->dev->mode_config.connection_mutex, &ctx); if (!ret) { - if (funcs->detect_ctx) + if (connector->force == DRM_FORCE_OFF) + ret = connector_status_disconnected; + else if (funcs->detect_ctx) ret = funcs->detect_ctx(connector, &ctx, force); else if (connector->funcs->detect) ret = connector->funcs->detect(connector, force); @@ -317,6 +319,9 @@ drm_helper_probe_detect(struct drm_connector *connector, if (ret) return ret; + if (connector->force == DRM_FORCE_OFF) + return connector_status_disconnected; + if (funcs->detect_ctx) return funcs->detect_ctx(connector, ctx, force); else if (connector->funcs->detect) -- 2.17.1