Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 17 Sep 2018 17:36:15 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Vaibhav Nagarnaik <vnagarnaik@google.com>
Cc:     linux-kernel@vger.kernel.org, Jason Behmer <jbehmer@google.com>
Subject: Re: [PATCH] ring-buffer: Allow for rescheduling when removing pages
Message-ID: <20180917173615.7001c80c@gandalf.local.home>
In-Reply-To: <CAL26m8L7f5iw_eNqbB2OVJX4vYebHcjiBJCQxyd_L4WjNFMb7A@mail.gmail.com>
References: <20180907182131.144514-1-vnagarnaik@google.com>
        <20180907223129.71994-1-vnagarnaik@google.com>
        <CAL26m8+C3tPJLy38i4LajM1_9B+x_AOOvUTot-VUkpHTZfFKmA@mail.gmail.com>
        <20180917170055.1f1d161f@gandalf.local.home>
        <CAL26m8L7f5iw_eNqbB2OVJX4vYebHcjiBJCQxyd_L4WjNFMb7A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 17 Sep 2018 14:02:59 -0700
Vaibhav Nagarnaik <vnagarnaik@google.com> wrote:

> On Mon, Sep 17, 2018 at 2:01 PM Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > On Mon, 17 Sep 2018 13:53:05 -0700
> > Vaibhav Nagarnaik <vnagarnaik@google.com> wrote:
> >  
> > > Hi Steven,
> > >
> > > Does the patch look good? Can this be picked up in the next rc?
> > >  
> >
> > Yes it's fine. I can pick it up. Does it need to be marked for stable?  
> 
> Thanks.
> 
> It'd be great to be marked for stable, since older kernels are also
> affected. But I can't judge if it crosses the threshold as a bug fix.
> 

When backporting to stable I use two (admittedly subjective) metrics.
One is the severity of the bug (this is low), the other is the risk of
adding it (this is even lower). If the severity divided by the risk is
high enough, I tag it for stable. Because the risk is so low, I have no
problems with tagging it.

Note, it will run through lots of tests before it gets out the door.

-- Steve