Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4533039imm; Mon, 17 Sep 2018 16:01:02 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZqum4i2Fjdb2yxWAQ49s/ZRkin+D/1ZPfRtp9Ydl0C7jxEEhNEBn2yeowJJUzP5ghzPIGa X-Received: by 2002:a63:31c2:: with SMTP id x185-v6mr25278806pgx.373.1537225262307; Mon, 17 Sep 2018 16:01:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537225262; cv=none; d=google.com; s=arc-20160816; b=byoBDKqjpHPQNumY2tfbOC6Srr6+eaIkHVV0HwuN6OxkPLL3FqY02gAuNfZlVndaKo 619tOWQdqkhxQWODTW7S5Kjth1umdldUqVzy6d5KvKCY95XTP3dpnh3orruCHRjRT+JA hvbbePjiFs8YxEuiW7J30dLNAgHS2eqRo34BdGSRX9+Mllql/EJGZBWvg87dUZnoRgF7 5HMZ4QZEkT9ay3aqauWf1fhRyDd/GVroAAvYJ5DSg0qT8UJaK3Y6luu/3A9cmQau8H6M JpXEnitEtYltOyj/7JhLNrkISuroulTgMVi2eH8I3PeiYKMYwWnk1cEwnL5Y0L4O7eRP pxmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from; bh=r77B7BptsRbxBQQ8HAo7ynOrG/QfRlf0QTAELTKEBic=; b=HjBwiiJUiM7jd2W8LUv8j5c3G8X/T1coEWPE/i6/CfJp+dVniHPel2B1WWyHI7m0gk ONi7ZOdLrcDD5lQZhhVMfaoioa0W+kTUQfZ+roeHYhH/Z0LkZDozFmgUuqe+94iBiRKX oTFP0v1KaIZQMrbLkefUiqRpf5ngRbx63MRaiNcmf2p4cSkLnZx1Y9iqACxEz5RRePv3 R6ZxZHQE2x4V5O8+/y8habe0xeh4nqSmnw/HSxPve7VzwwMTzeIy3o/0Z3f/r7AAIq2I YOUA8PSYiiCyq8sZyBIerjTnWZzV7XJCfLZ+bnf6uGfyILGDqU2yA54RTNheDKq42h9/ maxg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u1-v6si16767149plb.291.2018.09.17.16.00.46; Mon, 17 Sep 2018 16:01:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730040AbeIREaI (ORCPT + 99 others); Tue, 18 Sep 2018 00:30:08 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48110 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727559AbeIREaI (ORCPT ); Tue, 18 Sep 2018 00:30:08 -0400 Received: from localhost (li1825-44.members.linode.com [172.104.248.44]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 7AE88C03; Mon, 17 Sep 2018 23:00:40 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Florian Fainelli , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 023/126] ethtool: Remove trailing semicolon for static inline Date: Tue, 18 Sep 2018 00:41:11 +0200 Message-Id: <20180917211706.288399837@linuxfoundation.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20180917211703.481236999@linuxfoundation.org> References: <20180917211703.481236999@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Florian Fainelli [ Upstream commit d89d41556141a527030a15233135ba622ba3350d ] Android's header sanitization tool chokes on static inline functions having a trailing semicolon, leading to an incorrectly parsed header file. While the tool should obviously be fixed, also fix the header files for the two affected functions: ethtool_get_flow_spec_ring() and ethtool_get_flow_spec_ring_vf(). Fixes: 8cf6f497de40 ("ethtool: Add helper routines to pass vf to rx_flow_spec") Reporetd-by: Blair Prescott Signed-off-by: Florian Fainelli Signed-off-by: David S. Miller Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- include/uapi/linux/ethtool.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/include/uapi/linux/ethtool.h +++ b/include/uapi/linux/ethtool.h @@ -898,13 +898,13 @@ struct ethtool_rx_flow_spec { static inline __u64 ethtool_get_flow_spec_ring(__u64 ring_cookie) { return ETHTOOL_RX_FLOW_SPEC_RING & ring_cookie; -}; +} static inline __u64 ethtool_get_flow_spec_ring_vf(__u64 ring_cookie) { return (ETHTOOL_RX_FLOW_SPEC_RING_VF & ring_cookie) >> ETHTOOL_RX_FLOW_SPEC_RING_VF_OFF; -}; +} /** * struct ethtool_rxnfc - command to get or set RX flow classification rules