Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4538150imm; Mon, 17 Sep 2018 16:06:21 -0700 (PDT) X-Google-Smtp-Source: ANB0VdahUICRpEPpPVqdccM/jqanssoPm90d4EAtf2Uj/Jsk7Wdjp6yX6fYDRRsCZH4FPUu59GuE X-Received: by 2002:a63:ca09:: with SMTP id n9-v6mr25073839pgi.287.1537225581678; Mon, 17 Sep 2018 16:06:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537225581; cv=none; d=google.com; s=arc-20160816; b=WYt421Hv5dUtMioNkxZMitkRC2SocTKaz4fgZvLhmoLMW22Y0q4cfz1tQtURzbITQ0 GOYFrwgKvTKR52Hz/lVaQE4c7AyMURTtTQgSXEm7+PstVWtvG/PiPTwoN006YgcErxug CgFcT28sdtWHdSfHqc6CD7K2AZz4MABiyrsafAhB0KVCODfDsxo5i5iWqiBrGSRWIssC 8X2I5dXd9Lv+B/yieAL2CKlyhNKz8ViAA0D5PAtgAq/B7F2704RxGi8d3zo93RwW1c0t 7y97fnJtQJcGxGwPBEHJ3W2HQkYHUgwwkj1DlN8XbB2V2Nsm3e6UTaHvBfsfeUhPKUG+ MAYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from; bh=CWYqXAPAuIjpIdCtnpN1LnuBvpfYSWY5Ic0NX9gO16A=; b=BdIZd4qogVtBpBPZoz0nVhAIkctRgRiFuuQBwVpVIpq2ajfJDrwHKEW6NXz+U+jq1H QoqzQzeWB3Z/7zcHy/DyvpVOumPLtIcgtjsdC7OGD2lGjjaEPYljp3tVpcGmaUwrae5S McEbTmZZQ9m5U2WwlOIzx+BkAWZ/pQiXKN6bCK/IYSdetF4J6V5vRaPy7KjHcpAiSsSO v1raCzmALo9EIZyx/uqig5WWuzDCnGFu0jR0VgtT4gyQlxKdTK7xZn0oGbwQOP3nBieM sJsuuVXfyELGgBf7N2bynLIaDJxR2UX78bdrIc3lR+nHysFgPTpnLtWvMVkHjIWJg0Lj K2fw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d7-v6si16682881plo.253.2018.09.17.16.06.06; Mon, 17 Sep 2018 16:06:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731197AbeIREf3 (ORCPT + 99 others); Tue, 18 Sep 2018 00:35:29 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49414 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730202AbeIREf2 (ORCPT ); Tue, 18 Sep 2018 00:35:28 -0400 Received: from localhost (li1825-44.members.linode.com [172.104.248.44]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 23F23C49; Mon, 17 Sep 2018 23:05:58 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Chao Yu , Jaegeuk Kim , Sasha Levin Subject: [PATCH 4.14 084/126] f2fs: Fix uninitialized return in f2fs_ioc_shutdown() Date: Tue, 18 Sep 2018 00:42:12 +0200 Message-Id: <20180917211709.599110724@linuxfoundation.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20180917211703.481236999@linuxfoundation.org> References: <20180917211703.481236999@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter [ Upstream commit 2a96d8ad94ce57cb0072f7a660b1039720c47716 ] "ret" can be uninitialized on the success path when "in == F2FS_GOING_DOWN_FULLSYNC". Fixes: 60b2b4ee2bc0 ("f2fs: Fix deadlock in shutdown ioctl") Signed-off-by: Dan Carpenter Reviewed-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- fs/f2fs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -1803,7 +1803,7 @@ static int f2fs_ioc_shutdown(struct file struct f2fs_sb_info *sbi = F2FS_I_SB(inode); struct super_block *sb = sbi->sb; __u32 in; - int ret; + int ret = 0; if (!capable(CAP_SYS_ADMIN)) return -EPERM;