Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 18 Sep 2018 01:07:58 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Reinette Chatre <reinette.chatre@intel.com>
Cc:     tglx@linutronix.de, fenghua.yu@intel.com, tony.luck@intel.com,
        mingo@redhat.com, acme@kernel.org, gavin.hindman@intel.com,
        jithu.joseph@intel.com, dave.hansen@intel.com, hpa@zytor.com,
        x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 2/6] perf/core: Add helper to obtain performance
 counter index
Message-ID: <20180917230758.GA3117@worktop.programming.kicks-ass.net>
References: <cover.1536685533.git.reinette.chatre@intel.com>
 <6f93048a74c66a275f8eb6e1298f10552d1e5d95.1536685533.git.reinette.chatre@intel.com>
 <20180917082336.GP24124@hirez.programming.kicks-ass.net>
 <fdb736aa-3c2a-67d3-473f-b5a2a7d2c0e5@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fdb736aa-3c2a-67d3-473f-b5a2a7d2c0e5@intel.com>
User-Agent: Mutt/1.5.22.1 (2013-10-16)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Sep 17, 2018 at 09:37:14AM -0700, Reinette Chatre wrote:
> On 9/17/2018 1:23 AM, Peter Zijlstra wrote:

> > I said arch/x86/include/asm/perf_events.h and call it:
> > x86_perf_rdpmc_index().
> > 
> > This function is very much x86 specific.

> Moving it to arch/x86/include/asm/perf_event.h is not trivial since this
> file is not familiar with struct perf_event.

Urgh, right you are. Does it work if you make it a regular function
instead of an inline? Put the thing in arch/x86/events/core.c or so and
only an extern decl in asm/perf_event.h.