Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4643718imm; Mon, 17 Sep 2018 18:38:52 -0700 (PDT) X-Google-Smtp-Source: ANB0VdY2iX87GMzvnz2WEf0m70ya4pPU5NU+NbTGLBiq/qlbzS767sdUMdDeUedQeHCXB3cKNv7n X-Received: by 2002:a17:902:7447:: with SMTP id e7-v6mr27151090plt.186.1537234732604; Mon, 17 Sep 2018 18:38:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537234732; cv=none; d=google.com; s=arc-20160816; b=JkMkd80AbbKE6GvrcTPrzKsYKqbvrt5mYT35Ch04qKoUH4jPKGOkDaLrVdg3acJ5G4 DPZWNrGu32+aPIhGX68rLKPD7vsSQ5WocrxMeEZ9D8TyXWimcTyHrJQJo/7Nxbla0oHY ugKmgLv/TiypL9pnPrr6ntTEjpw4MlKICQL9uAlPwQ2FRYBCMdHWWL3WFQ3w6r7QpNJj KeQp1ZZitublk2QoOUBAXbCAsIGr6Drt/bazQfDSfoe96+KWYyLlz9qUjhT3OzaovuiH a7UFKYE4CqYvDGTEkbLtawLmnntsxNznD6LV5+85MXUWQWh6LIuikNchj9xIdsm7M9rm CIrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version:dkim-signature; bh=sd7BnCTIuB6QsPKifQZfeW2sQKoRHH5pxGY/thMdjKI=; b=Uqtc57Ri6ipLRCftazxAy6C4VY0Wdeod/NDZLrbA7TZZyJm3uooEKj1N3sCZqUvsqH n3LbyvzWjdeCbYXoVzbG1dFgZCAPCBhQqsK+uVB+8ItfoHGTnCzUHqE7F+niLA6Zhv3R dqHcuNIbI42ohviCMK657VWEB5HWa+55fpW1hWP1zo1ZFLsV6Q7exc/31ybqoVs2UQH+ 1CysC4OvFNIa1CEmgtLWMrTwnfftQCbI00O6WXkDhuzsSuj7Tju8PiuL1my2EJ+6EB1G qDWWXX6fIzYTprPzwNKFpCZYFxWgMfdMLebw+e6ArE3xNx3YGAieJoAFb53aS5H+ZaRG wt2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@me.com header.s=04042017 header.b=ANTCcGY6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=me.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j3-v6si16336851pld.402.2018.09.17.18.38.37; Mon, 17 Sep 2018 18:38:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@me.com header.s=04042017 header.b=ANTCcGY6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=me.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728644AbeIRHIZ (ORCPT + 99 others); Tue, 18 Sep 2018 03:08:25 -0400 Received: from st14p23im-asmtp003.me.com ([17.164.101.13]:45320 "EHLO st14p23im-asmtp003.me.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727263AbeIRHIZ (ORCPT ); Tue, 18 Sep 2018 03:08:25 -0400 X-Greylist: delayed 3612 seconds by postgrey-1.27 at vger.kernel.org; Tue, 18 Sep 2018 03:08:24 EDT Received: from process-dkim-sign-daemon.st14p23im-asmtp003.me.com by st14p23im-asmtp003.me.com (Oracle Communications Messaging Server 8.0.2.2.20180531 64bit (built May 31 2018)) id <0PF800O006TDMX00@st14p23im-asmtp003.me.com>; Tue, 18 Sep 2018 00:38:21 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=04042017; t=1537231100; bh=sd7BnCTIuB6QsPKifQZfeW2sQKoRHH5pxGY/thMdjKI=; h=Content-type:MIME-version:Subject:From:Date:Message-id:To; b=ANTCcGY61Z2EYLuC262KP3R30MyIKfaRqyqaVvDIDNsEfq2TicKAyAgVWtjGZ9txh rToaNMlKYGIZdT2g2uTu5LTdykYIW1wWS/vqbnJcbtxkhUHprKLnGsHnwjBPyqdgf7 RFz8oZXkOC4EFuwTZ1s9Asa8OdlYIV2c8xwEllCJDCd35Hx2x2WgQ1hc6OrDL22IPr mSpgUTFHPDSdG0rSqzCmswstgPFrn9NFikWQXojg8xPpu8KRuX3hbu0xZqhLB02TAk evttZ44meU2ds+HI4rB7cTz34jcmmS09j0Vx/FUC/Lg1UdU/8RD+aGtCGjSDr+ZVfJ qzkn6mSFAh1aA== Received: from icloud.com ([127.0.0.1]) by st14p23im-asmtp003.me.com (Oracle Communications Messaging Server 8.0.2.2.20180531 64bit (built May 31 2018)) with ESMTPSA id <0PF801B2673URA20@st14p23im-asmtp003.me.com>; Tue, 18 Sep 2018 00:38:20 +0000 (GMT) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=2 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 mlxscore=0 mlxlogscore=920 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809180004 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-09-17_13:,, signatures=0 Content-type: text/plain; charset=us-ascii MIME-version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: [PATCHv2 2/2] scsi: ibmvscsis: Ensure partition name is properly NUL terminated From: Bryant Ly In-reply-to: <20180911192226.3620-3-labbott@redhat.com> Date: Mon, 17 Sep 2018 19:38:17 -0500 Cc: "Bryant G. Ly" , Michael Cyr , Kees Cook , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Content-transfer-encoding: 7bit Message-id: <8E56DEE3-6A6D-49E5-81D0-0E26CDBC28A6@me.com> References: <20180911192226.3620-1-labbott@redhat.com> <20180911192226.3620-3-labbott@redhat.com> To: Laura Abbott X-Mailer: Apple Mail (2.3445.9.1) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Sep 11, 2018, at 2:22 PM, Laura Abbott wrote: > > While reviewing another part of the code, Kees noticed that the > strncpy of the partition name might not always be NUL terminated. Switch > to using strscpy which does this safely. > > Reported-by: Kees Cook > Signed-off-by: Laura Abbott > Reviewed-by: Kees Cook > --- > v2: Switch to strscpy instead of just strlcpy > --- > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bryant G. Ly bly@catalogicsoftware.com I sent a PR to update my email from bryantly@linux.vnet.ibm.com a week ago. -Bryant