Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4893980imm; Tue, 18 Sep 2018 00:34:05 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYUMumAoQucT/btbxjYxqmWw3W3tQbLKJxuzgdLQM1ryGUPevfK0digzvWlVMSZ05Jh64Y4 X-Received: by 2002:a62:3545:: with SMTP id c66-v6mr29159326pfa.63.1537256045340; Tue, 18 Sep 2018 00:34:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537256045; cv=none; d=google.com; s=arc-20160816; b=DhuO4FvtgxvdG1RhPTHne4GsxG4ce4bppkP3vBms7+li1hyIZ+MTe4526jyHPmVwTU EHNOmgCJIx0ycsCj0/KZ79boPMXYhqEiYkCfIabblYTbMLTGUzgWs9z+jRwPSHuj7Re3 2mDMWvBSBb6NgUbI+4q7NYJ7kKVGJNJon9L390dy3R/xyMSC6DI4NlK/HNt7AtJWWwpt JyCvkczqSg/qC4F32mq4lyN0Gov9q1jmdob3Np1qYBrNZBVF6EFmRIUiNyg8GxDBi2pe gwXpSvw+1BoyxRivqVNsMUE3BZ4kV90bkyn3XtY5/onNPlXC4lhhlIz3tqKXLRY8IS75 ce1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=sKgGJauRyU8Im/O3ZfgwWmGgncQeTpVlTQQ6DAwFVNo=; b=kuXuK1zAq+lQJaTpEVSJA62SvMvmyY1eqpMUfCupK8a8zZVyRAnAmX3UlOr8gV3itx WC6qoc78wOrZv139+pxdKRyt5TsOQlpxf8BILBXgd66rJ8ghsZhuAvqrpwyVUET1nt7x OBNCU9bs9PUG64cO4OnvbnckgdBs5g5cSx6HfoPw8hB4bH2tDs/RgQ3pHsFWgDfDXsMc OxCiRGS6LVaxFbIb9hpP2XoikJrl76m/o+0o7VmpacfLCHIhNQIeVKqt1y+FNUTgirin +5dr/7nwjnO5GiylAxZpKAQjoEVrzjpamnyZSYM+MoE+0knSwowUX3v1M4nGvNBCwgNE 5D+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=znjkq8uF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 19-v6si17398422pgl.667.2018.09.18.00.33.50; Tue, 18 Sep 2018 00:34:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=znjkq8uF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729147AbeIRNEw (ORCPT + 99 others); Tue, 18 Sep 2018 09:04:52 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:45348 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728649AbeIRNEv (ORCPT ); Tue, 18 Sep 2018 09:04:51 -0400 Received: by mail-wr1-f66.google.com with SMTP id 20-v6so873201wrb.12 for ; Tue, 18 Sep 2018 00:33:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sKgGJauRyU8Im/O3ZfgwWmGgncQeTpVlTQQ6DAwFVNo=; b=znjkq8uFQG77DstG7hfrxyH0RcaGAXDm7Ep2XyAl59aJRuI0Ua1T77jeWo6TpqlEB9 IsZrcs3P9mw4f0JOFQWh35tDK4hrqMi03T81i5xzltnlEHrORNxonwZ2f4yiK9K2MWeW axYmL6yXsKsUgzNXMIHUhzp1cf6h8bMF3sSF3oJB/BJKvHtCpUJ63Xwq2kZOL9YtaDQ1 vxF1p82s1XuvGodumxh9eMgwHfTEJy7B7L3k55OGWduxNs95eSZ9CtMYP/+z7tWdMgrl cN/mDNYDyv3pD1NVgM79n7jbNfbvItU/AJfx3OajMVfQvQJXhlobIdLf5kvRK0an8sZH Jyag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sKgGJauRyU8Im/O3ZfgwWmGgncQeTpVlTQQ6DAwFVNo=; b=IoOnI9l4hvGa9ScunA9wdVqRRS8RUzdbGh/jlb2JNsi5FLDKaa29B+hjz6S25FiLAs B5kzHF6BQY6jqi9g+sJE++5v+BlhJfqVokGhyeeSnncKAhGbheVtsL1DyH0EhG065Eb1 rhPepWS4Qdp2pguK5Xk06Kf2+vj5PFsTQYusr4a15cUU6qh8EgS7ZOelB4JkQotxPfH6 8RbSwZOJSXV7Ctu1LtKMyD1/e3PFXiD8b2+ZVHUZENFJSKiG9rToQCJwYTJScN7Uf6MV 6PKKJDCJlIzQnxH1dn55BF32EHm7M3hSx1K7WvMDbWyUfIO/Hmyeet/lOqgXB3XIYm2s D5Zg== X-Gm-Message-State: APzg51A+C1JcEFUPSB50ue7Jrt9sQWATt/1dkN7Lu1U5AXklInsOHUSe jl02Lu+GwTV12sf2WiwPVGTIfA== X-Received: by 2002:adf:81c3:: with SMTP id 61-v6mr22514376wra.120.1537256009693; Tue, 18 Sep 2018 00:33:29 -0700 (PDT) Received: from localhost.localdomain ([51.15.160.169]) by smtp.googlemail.com with ESMTPSA id r13-v6sm1138842wmf.35.2018.09.18.00.33.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 18 Sep 2018 00:33:29 -0700 (PDT) From: Corentin Labbe To: davem@davemloft.net, jdmason@kudzu.us Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Corentin Labbe Subject: [PATCH v2 1/2] net: neterion: s2io: Use linux/io-64-nonatomic-lo-hi.h Date: Tue, 18 Sep 2018 07:33:13 +0000 Message-Id: <1537255994-39517-2-git-send-email-clabbe@baylibre.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1537255994-39517-1-git-send-email-clabbe@baylibre.com> References: <1537255994-39517-1-git-send-email-clabbe@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch replace the custom definition of writeq/read and use ones defined in linux/io-64-nonatomic-lo-hi.h. Signed-off-by: Corentin Labbe --- drivers/net/ethernet/neterion/s2io.c | 1 + drivers/net/ethernet/neterion/s2io.h | 22 +--------------------- 2 files changed, 2 insertions(+), 21 deletions(-) diff --git a/drivers/net/ethernet/neterion/s2io.c b/drivers/net/ethernet/neterion/s2io.c index f980f10..6266032 100644 --- a/drivers/net/ethernet/neterion/s2io.c +++ b/drivers/net/ethernet/neterion/s2io.c @@ -75,6 +75,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/net/ethernet/neterion/s2io.h b/drivers/net/ethernet/neterion/s2io.h index 1a24a72..0a921f3 100644 --- a/drivers/net/ethernet/neterion/s2io.h +++ b/drivers/net/ethernet/neterion/s2io.h @@ -10,6 +10,7 @@ * system is licensed under the GPL. * See the file COPYING in this distribution for more information. ************************************************************************/ +#include #ifndef _S2IO_H #define _S2IO_H @@ -970,27 +971,6 @@ struct s2io_nic { #define RESET_ERROR 1 #define CMD_ERROR 2 -/* OS related system calls */ -#ifndef readq -static inline u64 readq(void __iomem *addr) -{ - u64 ret = 0; - ret = readl(addr + 4); - ret <<= 32; - ret |= readl(addr); - - return ret; -} -#endif - -#ifndef writeq -static inline void writeq(u64 val, void __iomem *addr) -{ - writel((u32) (val), addr); - writel((u32) (val >> 32), (addr + 4)); -} -#endif - /* * Some registers have to be written in a particular order to * expect correct hardware operation. The macro SPECIAL_REG_WRITE -- 2.7.4