Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4945625imm; Tue, 18 Sep 2018 01:37:21 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZEzB6n3eZqeTQF0ty0TUAi9pauplaztlDvfIfNNp0fIRHB1FeMyYxdTsUQZm8wKtRmQzNm X-Received: by 2002:a17:902:b81:: with SMTP id 1-v6mr28690852plr.319.1537259841753; Tue, 18 Sep 2018 01:37:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537259841; cv=none; d=google.com; s=arc-20160816; b=mh7Ggm6d9rzXPK7RSSbmqDCetKb0Lev6JrrUXIgjsxpbM5OTTlTkTWm/ykITPbaF2U lqD5thfejxjeDpIYRVpB3FJ3z8mmTxmMxbo2u72Vb9W9OJqXaGKckAEdwU+KLSIaumIa lTAc7M7Aj+Bi+WQRMaJAGJIavSbtuGenuxDTX7hW+wBxl+aoAMwM5FxQmSjv9RP2wvmo 9Xgh84Kbb3xqzskIKJcJcs1uyptQp1XzGZV6QytPDoGOf5HLaIM+BlRsBXWG189jAyJr ce8iFlowJtWSiGSsZJD8kCwaRlknwJ16GT13PEzpWWOL2DFa/n95pFfO5HWGClVCzqiB yAiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:references:in-reply-to:mime-version :dkim-signature; bh=pLLWcM4gQUZuoxdYcZ5Wwd2JH8nAR3Ld9T0G/svNncs=; b=chhAcMPV2o+ruf6WNcLlDL5Fz4xaPgB9lpK4mdVhFo2b8H0+LJd6DRGKAYY28Eacyg EfjyugN1mAc1OG+/nKyA6/CdaLJTTldQCQohOToUgEvbHu/ED8KIkUoq6J2yjVL7WmWX l/97IC9/r8J5H5ysg9mgDVObxIjPvkDqUjAmTKAO6LY75T22odZUhDlpa1b4VTMBkC71 Sd8WVT+XoIoy9GMdd6Tt06g8AD1k+8TNxm98gQIHu2uAW2xzXiGYIJ4fkPveLZA7afy4 xHmbm8jypQd7Lbv2XaPey5pFuSS6xg4UbNdYMggy2bmudpzjmAMXjSN1qicQFdVWoIfT mUmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@profitbricks-com.20150623.gappssmtp.com header.s=20150623 header.b=lEmUTxfy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u7-v6si18002745plr.46.2018.09.18.01.37.06; Tue, 18 Sep 2018 01:37:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@profitbricks-com.20150623.gappssmtp.com header.s=20150623 header.b=lEmUTxfy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729410AbeIROHG (ORCPT + 99 others); Tue, 18 Sep 2018 10:07:06 -0400 Received: from mail-ed1-f41.google.com ([209.85.208.41]:41701 "EHLO mail-ed1-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728842AbeIROHF (ORCPT ); Tue, 18 Sep 2018 10:07:05 -0400 Received: by mail-ed1-f41.google.com with SMTP id f38-v6so1176240edd.8 for ; Tue, 18 Sep 2018 01:35:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=profitbricks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=pLLWcM4gQUZuoxdYcZ5Wwd2JH8nAR3Ld9T0G/svNncs=; b=lEmUTxfyCrVlcioWiZIKK32T4gKPycy+zcES4T7btp4H2i0zVHj1He8/8TxdB0lDTv m1Wse5tqMCFZhW5zPmstrLhUogbXRZi4IC6naruKltA2QndmH5REW+HTWxDNHQGr0v0v ym3GSFvVt5MJBKg5QxzogUaYKAV6xA7JIszya+qLmHI/jooqu0Xb+jV4nhrfv81itd06 n/ZlBvxGPLJL8kXdKYmjXYRxomNZlFmOvRYfVf+Eg6l/UZ37PNMIUmAfx46FHl4gwwV/ 3MYW4F9HIMJVXfUKRGD2yIVlV47Jx4vQ736QQUMpqA+VrnZV8vw87MmV6lWepwqhu1nu TQ7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pLLWcM4gQUZuoxdYcZ5Wwd2JH8nAR3Ld9T0G/svNncs=; b=JD6iIMchgA9gmxtQ42z2DE+y6WSA9SFzRjuZSvWgfCPetYVk2eGhTmJ7rwMfib4hbc h7v3dQ4WfeNhQB1szNVXAOaPFLmZBM0X55kYnnOWT4CEYVyC8ZBkNkj43t9c22ah1M2j ySaI47NB+uOeMUMVma/BW7BvpiQfFyqJTlI45xAG1pXhr0N2Rr+WGgj+OZ6SJ5bmShmC qYoJlaBwVteErC+eKFWWzftPIcYyNHavccRmve/Z/mHlKMRZz5g9TKk/XN+IiQ14AjBE dHZ60OQYEwhOp1R1qyaapZUqn4wGU65HqHBwIu8okN2WbCTsvS+jhHDYhMojisU4HkfE w8Ow== X-Gm-Message-State: APzg51CWIdBpeuP0ruhN0NS9qpbslufQma33FkbUBWd5BCez3/lQsls3 mqTT0uApZFtO/MQcwC7NG1uQr3Gb6VgP/B/2UAAoiw== X-Received: by 2002:a50:8141:: with SMTP id 59-v6mr49230774edc.61.1537259730633; Tue, 18 Sep 2018 01:35:30 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:aa7:d499:0:0:0:0:0 with HTTP; Tue, 18 Sep 2018 01:34:50 -0700 (PDT) In-Reply-To: <1536852930-18926-1-git-send-email-jinpuwang@gmail.com> References: <1536852930-18926-1-git-send-email-jinpuwang@gmail.com> From: Gi-Oh Kim Date: Tue, 18 Sep 2018 10:34:50 +0200 Message-ID: Subject: Re: [PATCH] md: bitmap: use mddev_suspend/resume instead of ->quiesce() To: Jack Wang Cc: shli@kernel.org, NeilBrown , linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, Jack Wang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 13, 2018 at 5:35 PM, Jack Wang wrote: > From: Jack Wang > > After 9e1cc0a54556 ("md: use mddev_suspend/resume instead of ->quiesce()"= ) > We still have similar left in bitmap functions. > > Replace quiesce() with mddev_suspend/resume. > > Also move md_bitmap_create out of mddev_suspend. and move mddev_resume > after md_bitmap_destroy. as we did in set_bitmap_file. > > Signed-off-by: Jack Wang Reviewed-by: Gioh Kim --=20 GIOH KIM Linux Kernel Entwickler ProfitBricks GmbH Greifswalder Str. 207 D - 10405 Berlin Tel: +49 176 2697 8962 Fax: +49 30 577 008 299 Email: gi-oh.kim@profitbricks.com URL: https://www.profitbricks.de Sitz der Gesellschaft: Berlin Registergericht: Amtsgericht Charlottenburg, HRB 125506 B Gesch=C3=A4ftsf=C3=BChrer: Achim Weiss, Matthias Steinberg, Christoph Steff= ens