Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp5070692imm; Tue, 18 Sep 2018 03:59:49 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaS619eocU4QSTbddQP/DTBW0T/9Gg7kzGj99ekp6d0uSXHBcO+v1uhVxHDZhXzougWnS3d X-Received: by 2002:a62:ad9:: with SMTP id 86-v6mr30323937pfk.57.1537268389657; Tue, 18 Sep 2018 03:59:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537268389; cv=none; d=google.com; s=arc-20160816; b=lCmfa/Sc181t0o3WbVKlTNSETqYvShXA0cg33rbZH2woxvPsQNSQ25mRdG1K/xHkye thXS9UpLBYAOYiKjXRQ5b/sDMEVdweIvmo3LI6x+IjB9a8wTqIkCTN+7kUlxSeojmhAz QTEy3UzK8fl26+E/QuLAZAohztrwLOYCMNM4E1BL4NEXr9vI5XdNEejs3XqIwsJ+gno4 GydJVs8HsC7jVDl3DrLHcmB5rcjyjFmlf9qERskCREIP3GSyQoChiTPqe6+xUvnzPb1o 2B5OGwPMEHzwm6PUuL7iBheFdTNCaqN5Sm2CnzM58u1BCYRO5rLhRRI/RNHqTKvbTszX bgYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=p9MsDkwnPV+me7jonhn0p5eDYVk65VmMOttdBAAZQNY=; b=kmdIlPmTRfmafrAtnWIj4twwQbKCSFW9915HQ5YULTFpZKaM5IiWyU93FbJmyuuGur PiBkVznTNdm/Iyo7eRHj+1Rnu4aF+cWQdtozuefisb7FeknPjvE1djN3IpQ+9mjzCCcI JgRkuRBoCNCELYDkSbcfFV/4iJKR7CvXRITvU6N5Wblbg5z2HU4P83V4B42VVdA4XvuT nqL3KCD5+QF93EhCIjgYPGvCJeCtrZT2MIyS5Lm3wyr5wd7zNdj3ucWLCUNdMzp0P5za SiRNMkTqvFBD9Xd2LesyoXoPLD/eW8nnpu2pSYiaNr5ToMYhxmjEiK7+xM1yzBctlO4p LYdA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n7-v6si16747999pgp.411.2018.09.18.03.59.34; Tue, 18 Sep 2018 03:59:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729975AbeIRQ3v (ORCPT + 99 others); Tue, 18 Sep 2018 12:29:51 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:55698 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729945AbeIRQ3t (ORCPT ); Tue, 18 Sep 2018 12:29:49 -0400 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx08-.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id w8IAsLKw004527; Tue, 18 Sep 2018 12:56:37 +0200 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2mgryf0w8a-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 18 Sep 2018 12:56:37 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id A9AA831; Tue, 18 Sep 2018 10:56:36 +0000 (GMT) Received: from Webmail-eu.st.com (Safex1hubcas23.st.com [10.75.90.46]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 6D7F82AA2; Tue, 18 Sep 2018 10:56:36 +0000 (GMT) Received: from SAFEX1HUBCAS22.st.com (10.75.90.93) by SAFEX1HUBCAS23.st.com (10.75.90.46) with Microsoft SMTP Server (TLS) id 14.3.361.1; Tue, 18 Sep 2018 12:56:36 +0200 Received: from lmecxl0923.lme.st.com (10.48.0.237) by Webmail-ga.st.com (10.75.90.48) with Microsoft SMTP Server (TLS) id 14.3.361.1; Tue, 18 Sep 2018 12:56:35 +0200 From: Ludovic Barre To: Ulf Hansson , Rob Herring CC: Maxime Coquelin , Alexandre Torgue , , Gerald Baeza , Loic Pallardy , , , , , , Ludovic Barre Subject: [PATCH V2 23/27] mmc: mmci: add variant property to request a reset Date: Tue, 18 Sep 2018 12:55:40 +0200 Message-ID: <1537268144-21152-24-git-send-email-ludovic.Barre@st.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1537268144-21152-1-git-send-email-ludovic.Barre@st.com> References: <1537268144-21152-1-git-send-email-ludovic.Barre@st.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.48.0.237] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-09-18_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ludovic Barre Some variants could require a reset. STM32 sdmmc variant needs to reset hardware block during the power cycle procedure (for re-initialization) Signed-off-by: Ludovic Barre --- Documentation/devicetree/bindings/mmc/mmci.txt | 2 ++ drivers/mmc/host/mmci.c | 9 +++++++++ drivers/mmc/host/mmci.h | 4 ++++ 3 files changed, 15 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/mmci.txt b/Documentation/devicetree/bindings/mmc/mmci.txt index 03796cf..e952707 100644 --- a/Documentation/devicetree/bindings/mmc/mmci.txt +++ b/Documentation/devicetree/bindings/mmc/mmci.txt @@ -11,6 +11,8 @@ Required properties: - compatible : contains "arm,pl18x", "arm,primecell". - vmmc-supply : phandle to the regulator device tree node, mentioned as the VCC/VDD supply in the eMMC/SD specs. +depend of variant: +- resets : phandle to internal reset line. Optional properties: - arm,primecell-periphid : contains the PrimeCell Peripheral ID, it overrides diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c index b1d5bc5..6b3c33f 100644 --- a/drivers/mmc/host/mmci.c +++ b/drivers/mmc/host/mmci.c @@ -37,6 +37,7 @@ #include #include #include +#include #include #include @@ -1854,6 +1855,14 @@ static int mmci_probe(struct amba_device *dev, dev_dbg(mmc_dev(mmc), "clocking block at %u Hz\n", mmc->f_max); + if (variant->reset) { + host->rst = devm_reset_control_get_exclusive(&dev->dev, NULL); + if (IS_ERR(host->rst)) { + ret = PTR_ERR(host->rst); + goto clk_disable; + } + } + /* Get regulators and the supported OCR mask */ ret = mmc_regulator_get_supply(mmc); if (ret) diff --git a/drivers/mmc/host/mmci.h b/drivers/mmc/host/mmci.h index 7fd89b7..2d46a08 100644 --- a/drivers/mmc/host/mmci.h +++ b/drivers/mmc/host/mmci.h @@ -247,6 +247,7 @@ struct mmci_host; * @start_err: bitmask identifying the STARTBITERR bit inside MMCISTATUS * register. * @opendrain: bitmask identifying the OPENDRAIN bit inside MMCIPOWER register + * @reset: true if variant has need reset signal. */ struct variant_data { unsigned int clkreg; @@ -285,6 +286,7 @@ struct variant_data { bool qcom_dml; bool reversed_irq_handling; bool mmcimask1; + bool reset; unsigned int irq_pio_mask; u32 start_err; u32 opendrain; @@ -318,6 +320,8 @@ struct mmci_host { struct clk *clk; bool singleirq; + struct reset_control *rst; + spinlock_t lock; unsigned int mclk; -- 2.7.4