Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp5071921imm; Tue, 18 Sep 2018 04:00:58 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYxbGg6mr0WbuyC88gRR2Hd0lIZpLQ6jJBTkcGMjDzXqyvXXeTwsvZY5HloqGfRpnDPxDbq X-Received: by 2002:a63:f:: with SMTP id 15-v6mr27783803pga.430.1537268458274; Tue, 18 Sep 2018 04:00:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537268458; cv=none; d=google.com; s=arc-20160816; b=EX5sMrw8fxC138C0D9Ojuh7ThT6yqDeOm+kWGeL/blSMgWBuiYAnV0Y6LOF4wVh/jI srYl6bB9GGo0R1o5N7FIDAwzHqpj2Jz0YlvOU7yhABapbFrpdc104PYRaKsvG3AfT92M jLCgB3wU3gh8I+V+YQrjfQbTnZEu3PpKpfzoEE0M8KQxDa66uJCbFNmjgLx85pmzPj59 OXSSyV4huBY8tgD69KPNpc33ntjyYIpA1kZ8I2Z0Au4HRN2c+j/NHhyH45pQ+io3H+DL XgRPLN0/SEDRuwb+xn4Rx5El7/R9xdG+GoMPA7kXptwnQElgkoBVj0Opatboz8VakOxT 5pCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=g6Tei/JF4Zbv1+iYpQGZ7lpI3eNeLJeKOAI3btR/XzM=; b=SWddSNcagtaXawpkQQJzQQd6/1CZ+dUxa3lfNd1pff5Z9LT3XWR+/YFn54j7H/Jbfh of+noKOss7PXhH4gM7eAWl4NKgWXO2gsWOov4et/rOm+wD5G3GvtUTr3Jmm5K+/XYbh8 TozyGfwwkFCS1uH2SRGRhCzUxaLVa1JUOMGtk5e542meb2P4B0ha4SQIMgqAs2GQ+Llw BS5bymzBLRlGQU5ghtaxMA4rWXeM3PFvIC40opxNUvWbzA04KITExtdaOodX5HU+Nzbs 5wZi/T5d6WLof8mieGf/qOWSWrjmAUf+xDUXI9qFI58sco0iwnM45wnsgXM27iLs1cMF oJJw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r17-v6si17600257pgo.606.2018.09.18.04.00.42; Tue, 18 Sep 2018 04:00:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729762AbeIRQch (ORCPT + 99 others); Tue, 18 Sep 2018 12:32:37 -0400 Received: from foss.arm.com ([217.140.101.70]:42518 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729285AbeIRQch (ORCPT ); Tue, 18 Sep 2018 12:32:37 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BB7E0ED1; Tue, 18 Sep 2018 04:00:32 -0700 (PDT) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8DB473F5BD; Tue, 18 Sep 2018 04:00:32 -0700 (PDT) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id 69A9B1AE1181; Tue, 18 Sep 2018 12:00:51 +0100 (BST) Date: Tue, 18 Sep 2018 12:00:51 +0100 From: Will Deacon To: Mikulas Patocka Cc: Sasha Levin , "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH AUTOSEL 4.18 032/136] arm64: fix infinite stacktrace Message-ID: <20180918110051.GB16498@arm.com> References: <20180917030006.245495-1-alexander.levin@microsoft.com> <20180917030006.245495-32-alexander.levin@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 18, 2018 at 06:55:34AM -0400, Mikulas Patocka wrote: > This patch is not correct, because the stacktrace is supposed to work > around discontiguous interrupt stacks. > > You should replace 'frame->fp <= fp' with 'frame->fp == fp'. No, just drop the patch. It was already reverted upstream in e87a4a92fba3. Can the AUTOSEL robot check for upstream reverts? Will