Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 18 Sep 2018 15:03:16 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Zhenzhong Duan <zhenzhong.duan@oracle.com>
Cc:     linux-kernel@vger.kernel.org, mingo@redhat.com,
        konrad.wilk@oracle.com, x86@kernel.org, dwmw@amazon.co.uk,
        tglx@linutronix.de, Srinivas REDDY Eeda <srinivas.eeda@oracle.com>,
        bp@suse.de, hpa@zytor.com, dhaval.giani@oracle.com
Subject: Re: [PATCH] x86/speculation: Use AMD specific retpoline for inline
 asm on AMD
Message-ID: <20180918130316.GP24142@hirez.programming.kicks-ass.net>
References: <87411705-893f-46d3-b899-b09ed9fa8d1b@default>
 <20180918095015.GE19234@hirez.programming.kicks-ass.net>
 <3fcc1453-1618-9a79-71c9-5eede0023775@oracle.com>
 <20180918105939.GK24106@hirez.programming.kicks-ass.net>
 <1c6ca05f-094e-03e9-b21a-866aaf80cebb@oracle.com>
 <20180918130058.GM24106@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180918130058.GM24106@hirez.programming.kicks-ass.net>
User-Agent: Mutt/1.10.0 (2018-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> > In original code, it will go to "call *%[thunk_target]\n" while
> > we have set SPECTRE_V2_RETPOLINE_MINIMAL or
> > SPECTRE_V2_RETPOLINE_MINIMAL_AMD. Is this expected?
> 
> Yes, that is exactly right -- it does that with or without your change
> though.

Soryr, I wrote that before I noticed the CONFIG_RETPOLINE vs RETPOLINE
thing.

In any case, since retpoline capable compilers are widely available, I'm
all for making CONFIG_RETPOLINE hard depend on it. That minimal stuff
really is quite silly.