Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp5237682imm; Tue, 18 Sep 2018 06:32:06 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdb/Uaj3wG1TUEKVBDDQY1t9pA7pLZUCGsdj6Ry0IC23OC41BtSlP0fy6tEqGDQ7fQpNJN0a X-Received: by 2002:a63:af17:: with SMTP id w23-v6mr28590883pge.47.1537277526276; Tue, 18 Sep 2018 06:32:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537277526; cv=none; d=google.com; s=arc-20160816; b=Qp+kpoGd8g7qbjcRrQDhGLMQ/+G5hU8sJwyRCl6QZUKWrjgV8DvVXJKjePkx8Mn4cO 9SY2oBmYRY4r3viYBNQeSIS/ZJiGH5CZyj7ngZYQB8CF8Cb7itAFlNs/V/8bRKhqkQ2I f5wr+uTrPUPllchroARFffMLdXITYrhbRZTpjdkK0Y06djJT8fQFsllhs8xCkZIhV8yd 1RLD/TpuHNmEhxKAVJLF4L8wWVVJc2fNIC/zwqddJvIyysysCJEnVGoboYO90/ZFMkgm gzSuYTkgMZBtKMSXw38XBXKEs5+QSfQ72aPPMjO96QCB94MavAwiCBA5ID2i+mU7t/eI 9/Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=p/3K8JZboV/3JB6TESe063ZKLuQp4/4kMur1SwsDgFs=; b=XU+SrcW27QSkh5Mw+eUVFgZkowUCegmFu6sUncnH2/gFaZUKX2NYY4lKdGEnDciCfy wXt+W51Dji+d1EjacDc5DgmZOzC28TfoG91kslSidM2rGe578tYWt17kfNRH0XNVxsmi M4dUEZJX6iy2bU8FPZ/fIC7R9ZRwA+qU/WKbMX8WAYqXHJhwcx0REQE9VCG+CjThvAhh 9g80A5g58U9xreyPiJoYECPQ/Z2iOyeQ/u7Lh7lyGwOnnt39h17FJgyx2mfg5eQpaNwL VHI9miaOh+mbLqGQP89Is92/4+0ELNXVnxJf5/Ofcy/LLsWm0rKBLsuB/ICsBcU/5wNl 0XXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: <linux-kernel-owner@vger.kernel.org> Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e8-v6si18417345plt.57.2018.09.18.06.31.43; Tue, 18 Sep 2018 06:32:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729801AbeIRTCi (ORCPT <rfc822;yxhlfx@gmail.com> + 99 others); Tue, 18 Sep 2018 15:02:38 -0400 Received: from mga18.intel.com ([134.134.136.126]:12875 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727207AbeIRTCi (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 18 Sep 2018 15:02:38 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2018 06:30:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,389,1531810800"; d="scan'208";a="74204953" Received: from chenyu-desktop.sh.intel.com (HELO chenyu-desktop) ([10.239.160.116]) by orsmga008.jf.intel.com with ESMTP; 18 Sep 2018 06:29:58 -0700 Date: Tue, 18 Sep 2018 21:36:44 +0800 From: Yu Chen <yu.c.chen@intel.com> To: "Rafael J. Wysocki" <rjw@rjwysocki.net> Cc: Thomas Gleixner <tglx@linutronix.de>, Pavel Machek <pavel@ucw.cz>, Rui Zhang <rui.zhang@intel.com>, Chen Yu <yu.chen.surf@gmail.com>, Zhimin Gu <kookoo.gu@intel.com>, Len Brown <len.brown@intel.com>, linux-kernel@vger.kernel.org, x86@kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 3/4][v2] x86, hibernate: Extract the common code of 64/32 bit system Message-ID: <20180918133643.GA3120@chenyu-desktop> References: <cover.1536685746.git.yu.c.chen@intel.com> <7266f9b93000c57edd41fcf2cee0dd4d6252a8ef.1536685746.git.yu.c.chen@intel.com> <3135968.eiNgRHp3gn@aspire.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3135968.eiNgRHp3gn@aspire.rjw.lan> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Sep 14, 2018 at 11:21:17AM +0200, Rafael J. Wysocki wrote: > On Tuesday, September 11, 2018 7:20:46 PM CEST Chen Yu wrote: > > From: Zhimin Gu <kookoo.gu@intel.com> > > > > Reduce the hibernation code duplication between x86-32 and x86-64 > > by extracting the common code into hibernate.c. > > > > No functional change. > > > > +#include "hibernate.c" > > I don't particularly like this. > > Why excatly do you need to include the C file here? > OK, I've removed this in a new version. > Also, the way this change is made makes it quite hard to review, as the > new code is not exactly the same as the code being removed, so it is > hard to say whether or not there really are no functional changes > as claimed. I've splitted the patch into several sub-patches and reorganized the code to make it more readable on a new version. > > This is sensitive code, mind you, and really hard to debug if anything goes > wrong. Please be super-careful about changing it. > Ok, will test on several platforms and send out the modification. Best, Yu > Thanks, > Rafael >