Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp5246794imm; Tue, 18 Sep 2018 06:40:10 -0700 (PDT) X-Google-Smtp-Source: ANB0VdafwX/HnFNYFwvyWtwhfw0R0+15y3tXrvDQhhKzxxX7t7j+W5P2EiDcfloeXxhZA8xkO+Ye X-Received: by 2002:a62:3703:: with SMTP id e3-v6mr30863925pfa.117.1537278010035; Tue, 18 Sep 2018 06:40:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537278010; cv=none; d=google.com; s=arc-20160816; b=y4RDOUjtVqwHNwgHIR28IQb9m+xbAHArPSChxkiEiIY8oiwG9jfpb09LJhAmKXSul4 GtzD9eUPvgyWf+tQxuSqQPkdt9Xv0Fc1D34JvsaYxnQgpD89wyvbhHX8mRJWC7/VRC9I PeaoDlerHVfNFY1ENmm1wLNLBOnWoT/LoqwGf6s+x/EPhkJdRmhHrEq25dVBsD1Klxko dSXRwEYrHM/W+KQAYAO7FYx7ft641Jjhm9u8H2AhFMeN5qnwnPSITY2wHWyYuUPrOr6j SOvETmlEE5PRSDGzSr64Wn9cHKTd1YuO9cjzUNfyuKvxWcQ/11iRk7l41FklKWlQ4xAF UJMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=T+/yEMYuDJl4Zd2/SUJ99KJQWIJSo6iDI/XQAfpVjwY=; b=b2AjBMh7ZSrXhNvUA4LeLXoQ7n81+DhxE7lja0NpKGORvWXPXzYK8KmxWRLnU//Ucn APDSVAj1ODFu3Rg+DaiZfXuZO6iPkIY/lb9h6UDaakrhBlMAxWLb4zlOKiWiatkyUHAq uVsHhCRT4wvBbVrcbLGd370LZnIckA6hmrhkbsGWV2dEEBVvMr+xjYnxQTXRFQl0TA7a Nt31GnZnAOcR2GC+aRWKvMJRiV0KKLjPkfv1CYGZluXO90NRpkJx0II1i0Bsksi+ToDr aeRLufK926A5eYVT5LGdzmDDF7Kq6afwDjJbKj+yZgauYfdzFSt2+mPZ4VxsdZXxrjTS ECrg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m7-v6si19435334pfm.288.2018.09.18.06.39.53; Tue, 18 Sep 2018 06:40:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729749AbeIRTKl (ORCPT + 99 others); Tue, 18 Sep 2018 15:10:41 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37970 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727207AbeIRTKl (ORCPT ); Tue, 18 Sep 2018 15:10:41 -0400 Received: from localhost (unknown [147.67.4.98]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 59A4D74; Tue, 18 Sep 2018 13:38:02 +0000 (UTC) Date: Tue, 18 Sep 2018 15:37:59 +0200 From: Greg Kroah-Hartman To: Anton Vasilyev Cc: Alan Cox , Jiri Slaby , linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH v2] tty: rocket: Fix possible buffer overwrite on register_PCI Message-ID: <20180918133759.GA20312@kroah.com> References: <20180802150201.316e3361@alans-desktop> <20180806141057.7105-1-vasilyev@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180806141057.7105-1-vasilyev@ispras.ru> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 06, 2018 at 05:10:57PM +0300, Anton Vasilyev wrote: > If number of isa and pci boards exceed NUM_BOARDS on the path > rp_init()->init_PCI()->register_PCI() then buffer overwrite occurs > in register_PCI() on assign rcktpt_io_addr[i]. > > The patch adds check on upper bound for index of registered > board in register_PCI. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Anton Vasilyev > --- > v2: do not enable device which will not be managed by driver. > Based on Alan's comment. This patch doesn't apply to my tree at all :( Can you rebase and resend? thanks, greg k-h