Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp5257914imm; Tue, 18 Sep 2018 06:50:34 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbqtyBmW10G327BCu+gkSPL2yEp0Vny/B7RGu9ih7kQYzLYjgLgs4ZArhzvmWKzkqNwKAIO X-Received: by 2002:a17:902:b784:: with SMTP id e4-v6mr29755555pls.204.1537278634243; Tue, 18 Sep 2018 06:50:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537278634; cv=none; d=google.com; s=arc-20160816; b=UzTv504tBhQGChdWbCR3R7t517j2DV+DIHjjals7SncWDvFnvKVdq9n93Gn49ER54n aoWQkIMFsmlKeYl3TR8TLJIUpszAdCiz1qhw8i9d2xOqld0FWVUE23qeECjJzX1BX5Kc MTiExLX89xI57lMvr9/+W8FyYXLQRPiU5TIF7HA6YP/ROWdykGLwAPueyamuFaPI0Wq2 jNAdAKuYRdZMe8jLEAsZfgb1gUZmC3YeVpqPh7q4zg/mT7VODNUeSpuO18oelzGfwX1o 01T8gvtXp3Y9q6571RG1RgBpopdxgNzuu4AhiPi2BhjSOAD6YO8tfymE0dQxsEgFJZqd eoAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=0C2LfnPqMnya9AoeGOBY6kXvaQE0XEnkLdZfsVR8p34=; b=aDxAYPkecZa9wFcL8T2J8zspW7ebARRk53MuOLNisPkEK1O9v1UlRRrZrZEMle0hu0 dT/JUCllG8F5LI/AdUOPiwptv9ELj9nerqHs3ieemrM8LljCXo8+53sNkgqkdHnP3akS oEc2tsOMd5GOaaw2EmyYSlriu9Lad/L9Er69QWAEnNOctWWvPdQlKe9lVVN7BbKU9jXK rqHX1BPUa3dJTuzOQarS/QKi6QAuT5DER+7NpRZw6qFNrNyjiK/E2mFlV4tWeAIdVF2D 3YQy/PiPmIQYhcbtl2znQPlpS8jFWLGCIqwJNsW4Sv1BUzqEx+Yri9SxUG8l/pNFwW+q eWMg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i3-v6si18183078plb.44.2018.09.18.06.50.18; Tue, 18 Sep 2018 06:50:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730184AbeIRTWk (ORCPT + 99 others); Tue, 18 Sep 2018 15:22:40 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:43172 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729889AbeIRTWj (ORCPT ); Tue, 18 Sep 2018 15:22:39 -0400 Received: from localhost (unknown [147.67.4.98]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id E4BFDC03; Tue, 18 Sep 2018 13:49:56 +0000 (UTC) Date: Tue, 18 Sep 2018 15:49:54 +0200 From: Greg Kroah-Hartman To: Dmitry Safonov Cc: linux-kernel@vger.kernel.org, Dmitry Safonov <0x7f454c46@gmail.com>, Daniel Axtens , Dmitry Vyukov , Mark Rutland , Michael Neuling , Mikulas Patocka , Nathan March , Pasi =?iso-8859-1?Q?K=E4rkk=E4inen?= , Peter Hurley , Peter Zijlstra , "Rong, Chen" , Sergey Senozhatsky , Tan Xiaojun , Tetsuo Handa , Jiri Slaby Subject: Re: [PATCHv5 6/7] tty/ldsem: Add lockdep asserts for ldisc_sem Message-ID: <20180918134954.GF23431@kroah.com> References: <20180917235258.5719-1-dima@arista.com> <20180917235258.5719-7-dima@arista.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180917235258.5719-7-dima@arista.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 18, 2018 at 12:52:57AM +0100, Dmitry Safonov wrote: > Make sure under CONFIG_LOCKDEP that each change to line discipline > is done with held write semaphor. > Otherwise potential reader will have a good time dereferencing > incomplete/uninitialized ldisc. Note, I don't see patch 5/7 here, did it get lost? Please fix that up for the next resend of this series. thanks, greg k-h