Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp5304925imm; Tue, 18 Sep 2018 07:31:25 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZOLPUaL9CyslQYLsB9Skn+NByGBGXCgFiRwIeOQCPGRSgtPJJxc9c98kSLnY/EkZy5x4/K X-Received: by 2002:a17:902:be07:: with SMTP id r7-v6mr29400688pls.275.1537281085120; Tue, 18 Sep 2018 07:31:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537281085; cv=none; d=google.com; s=arc-20160816; b=K01jnm/uZjXjirUy9BAdsC+l+qwblY04xCKEbd0vBFX7em5XG5LaLCR7tJdaYFB+jv noY897uwM6M9u+YGbhZsaid1JwmqHLYP3goBeiEsSoCGiQiesTuOQdos/yxqXuWDAd/i Q13nlmnkZgv+PiNt4m4f5rSTJQQZpLxLL8nCIBcc1bkgfgjaN3PSdItqP4wqwzyZ+1QR Ts8JarYexO/+vt2Mnx5NKXtG0H3jEkQoUG5oBsRFVMva8Z3pvTYz3cYtbGhqGi8bTaer z8uaWLH2eIWaud6ZN8KcLUUInE5oNvk/a4Z6qRdN/fHp/78yiz5cmjTR/EaNBAkPCSLc iikQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=x2eBv9ikFo3hBcDabL/h0lSwJsInxM/3tlIHwIhdg10=; b=an6aa0vwiqQlZ5y0WF4Gn/eM3PQaqAFbiHKNPWOL6RHCHBzUf3TwFRwz3NpgYHItC9 k+2Obalc6rt5q1WwgsFUFL8hscPjC4kCQ3GqQLsOQKenAidnqm4BF+YA1rcrG5k7SJ8X AEjkQLfNhnlFg4JmRm5VW2Ydcold7Iv+GZ2kpJC/ERU1GvRc9+7AHFtEEDQlGOhCP+Lx 6dbvOize9l6L3Q/3ZgRSCIbrDlWj/f+ZHh6WPVu6U0ZU2y7IdnLMa03F5TvBPZ3XTQL0 M88pS7RxsKsoI1CL/bg2MyZW6sBUZkZhGOpGhTkQo+ibiF2T7Tm2a1BoeJRh3V+SARSh 8ncw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QetEjJRz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id go1si19376335plb.266.2018.09.18.07.31.06; Tue, 18 Sep 2018 07:31:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QetEjJRz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729919AbeIRUDt (ORCPT + 99 others); Tue, 18 Sep 2018 16:03:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:50112 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728681AbeIRUDt (ORCPT ); Tue, 18 Sep 2018 16:03:49 -0400 Received: from [10.80.45.152] (unknown [71.69.156.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5570C2146D; Tue, 18 Sep 2018 14:30:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1537281057; bh=3z322m+pIgqj4BdzuLWJRh5NuCabufTNWbeRlfzLbt8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=QetEjJRzjU9zMe1PCWr6Q7WfMIF8wq3VoG5FPUfCvuBFY644kH7iTzT4d61OE4SO1 pa91qRUK7XSw4dlKj7r/oV/sY3rFdUPao9Tginedeo4QlrkH5T4f1keQXlFkvYNYwY iRZBGa/DlA0DCkM6gxCWeVZomeQMPcT5rCYVjE2o= Subject: Re: [PATCH] PCI/AER: Clear uncorrectable error status for device To: Oza Pawandeep , Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, Keith Busch , Wei Zhang , linux-kernel@vger.kernel.org Cc: Giovanni Cabiddu , Herbert Xu , "David S . Miller" , Dan Williams , Kees Cook , Sagi Grimberg , Adaptec OEM Raid Solutions , "James E . J . Bottomley" , "Martin K . Petersen" References: <1537258829-15763-1-git-send-email-poza@codeaurora.org> From: Sinan Kaya Message-ID: Date: Tue, 18 Sep 2018 10:30:52 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1537258829-15763-1-git-send-email-poza@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/18/2018 4:20 AM, Oza Pawandeep wrote: > +++ b/drivers/pci/pcie/err.c > @@ -265,6 +265,8 @@ static pci_ers_result_t broadcast_error_message(struct pci_dev *dev, > * The error is non fatal so the bus is ok; just invoke > * the callback for the function that logged the error. > */ > + if (cb == report_resume) > + pci_cleanup_aer_uncorrect_error_status(dev); > cb(dev, &result_data); > } In order to follow the existing behavior (drivers are calling pci_cleanup_aer_uncorrect_error_status() right before return), you should probably move the pci_cleanup_aer_uncorrect_error_status after cb(dev, &result_data); line.