Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262707AbTKNOQs (ORCPT ); Fri, 14 Nov 2003 09:16:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262714AbTKNOQs (ORCPT ); Fri, 14 Nov 2003 09:16:48 -0500 Received: from port-212-202-185-245.reverse.qdsl-home.de ([212.202.185.245]:43927 "EHLO gw.localnet") by vger.kernel.org with ESMTP id S262707AbTKNOQr (ORCPT ); Fri, 14 Nov 2003 09:16:47 -0500 Message-ID: <3FB4E3E2.3040203@trash.net> Date: Fri, 14 Nov 2003 15:17:06 +0100 From: Patrick McHardy User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031024 Debian/1.5-2 X-Accept-Language: en MIME-Version: 1.0 To: Matthias Andree CC: Linux-Kernel mailing list Subject: Re: [2.6] Nonsense-messages from iptables + co. References: <20031114132054.GA646@merlin.emma.line.org> In-Reply-To: <20031114132054.GA646@merlin.emma.line.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 932 Lines: 31 Matthias Andree wrote: >Who the heck added these unhelpful > >"ipt_hook: happy cracking." > >messages to iptables/mangling/connection tracking code? There are three >instances. > >If the kernel has got something to say, it should be clear what the >kernel means, say, maximum rate exceeded or something, not >such junk like this. > >This is IMHO a MUST-FIX before 2.6.0. > > The bug that led to that message is already fixed. The message itself might be stupid but is definitely not a must-fix item. Also, instead of changing the message statistics should be added to conntrack etc. to count unusual events instead of printing them to the console. Best regards, Patrick - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/