Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp5361337imm; Tue, 18 Sep 2018 08:20:38 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZxN6gwJ/YqnuYt3vxeVjrjD7sxgYNdOZcmKuHlkpTgA1MYbK6IbNJO8xON1AUi0kz6Tcvx X-Received: by 2002:a63:9dcd:: with SMTP id i196-v6mr28718816pgd.238.1537284038082; Tue, 18 Sep 2018 08:20:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537284038; cv=none; d=google.com; s=arc-20160816; b=ik1mUoRvUtDbzgVZhGgoBVQOGQyS88sBYeeKadUbCswlx5GYagkqp7I+O/hyUsMx2L 1MpU1OZguOqpmJlhb5TWtAzAlE/dYRhlK173jJCcZUBbR3609v3i2dhzMKd0NwZejkiX dSbEtQOfKD/XShpmUdyp9wd5oDigyc21V4ndIrwnNXDNn2EQQeJiiPhXKCyCI8Skd16O 1zv+3wD/oAAeeJWxQq8SIZJjBRQrEhTOVrmCWq3c6ea/wATbAlEuYQEyyhXWE595aDDF h0DP7SXHJjnJ3+rvjBuFjwm70ciyZiG4lg/O3JkCOs586tChJjyW4tWDEQ50PmD/mGC4 LWGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature; bh=5qIoN0hYeaglc05BP/qdQbwQQKHfCj5ZpaJkz8LE2/4=; b=taL94DppcVOYev8HEt53VBIpnyTSlFoM3ilQxYmykWH2X7fzIOA5scIZPqedKJOyFz bDkHaalXidl7NMtWYJg6wCpiFKu+3HvcNNMNDIq5WdjcKhi61jKsdrCD54sVsWpOrKl+ UB6Nw9Tvt8ETBpfQ/ri5pzT0x30wcGlHbQiKPOHoWHD2JvM7ocVwYQipzzGWPR1opCn2 7ut89eOX/SEWhu7srKA4nUShYxeb9yFKKbzBz3osOGwDYYyRDkC7ldlxxO3IPUC2NITd sraKYrfy2xI4V+yGt/25DYZlP6tSlwYUswvh7Nk2Cjpu1db7CVNbmLsT3XK8yzj00L3i /+vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@ffwll.ch header.s=google header.b=EtPW62WR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id go1si19376335plb.266.2018.09.18.08.20.21; Tue, 18 Sep 2018 08:20:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@ffwll.ch header.s=google header.b=EtPW62WR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729958AbeIRUwM (ORCPT + 99 others); Tue, 18 Sep 2018 16:52:12 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:40321 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727756AbeIRUwM (ORCPT ); Tue, 18 Sep 2018 16:52:12 -0400 Received: by mail-it0-f65.google.com with SMTP id h23-v6so3483223ita.5 for ; Tue, 18 Sep 2018 08:19:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=5qIoN0hYeaglc05BP/qdQbwQQKHfCj5ZpaJkz8LE2/4=; b=EtPW62WRxQN6dQyB2Xt96G180BwVS3Rvy26aNe2lBI8LeLYAb+Z2KKDPTSXaHUNSkD 2ZzOWiCgR2zwxluBGMr6+YOvmX5H9wFvU4zAHODQ6/29tao5Zm3IRoLyxO/FRKU8z+Wh ETacrOv/nTy6XKWnn6O0Sgitbkup82P5Wiap0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=5qIoN0hYeaglc05BP/qdQbwQQKHfCj5ZpaJkz8LE2/4=; b=Wfwu4QLnfMqgTFsByYIHeOL+wKE3xi+9oMf+hV+jSWRmVI9kK5xlUSjNvTc0WBfCYy uq1ec4harSqs6dfqhxSNPYAYnDcBoDikv2PZ89CN0ORFpdgNHHYzIwUZroppl7iem2/4 pLK3s/ObtpOQGtnOmUtH0GAL/fkLJxiKS5pC9NwO3GN5AQkI8YWGafdYWQOopyHxrjoL BlDnmRnfSfY0Q9PAE4/kM3gn7S3/XRNIT0NXJDJc6fqsayl7CiILYzUFb2Q8MKs2R/wq EqBvBPP6TpWOoNT88qsoADOgnOTEF1fJU1dZx7+FpKqTkr8AwHnmLUKMNJ86DUfqSRiv 6tag== X-Gm-Message-State: APzg51Ae7qtBmbzMcgQMZnQ+LVvA92RZ1IvuQHQwtUi7oNCwyxENJf5o fXnWbS8vxfWkQ8M1pPO9ckg9euZbnfFm4+hHSeexsjMoE+U= X-Received: by 2002:a02:b38c:: with SMTP id p12-v6mr26558141jan.79.1537283949508; Tue, 18 Sep 2018 08:19:09 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4f:6cc5:0:0:0:0:0 with HTTP; Tue, 18 Sep 2018 08:19:09 -0700 (PDT) X-Originating-IP: [2a02:168:569e:0:3106:d637:d723:e855] In-Reply-To: <20180827071824.GG3850@dragon> References: <1534472646-10368-1-git-send-email-zhongjiang@huawei.com> <20180827071824.GG3850@dragon> From: Daniel Vetter Date: Tue, 18 Sep 2018 17:19:09 +0200 X-Google-Sender-Auth: KrqEDgVS1HulppUMudA-xSag9Dg Message-ID: Subject: Re: [PATCH] gpu: do not double put device node in zx_drm_probe To: Shawn Guo Cc: zhong jiang , Dave Airlie , Linux Kernel Mailing List , dri-devel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 27, 2018 at 9:18 AM, Shawn Guo wrote: > On Fri, Aug 17, 2018 at 10:24:06AM +0800, zhong jiang wrote: >> for_each_available_child_of_node will get and put the node properly, >> the following of_node_put will lead to the double put. So just >> remove it. >> >> Signed-off-by: zhong jiang > > Acked-by: Shawn Guo Shawn, I'm assuming you'll push this to drm-misc-next? You're the maintainer with commit rights after all. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch