Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp5370854imm; Tue, 18 Sep 2018 08:29:43 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZaBUHhAal6ouCsSoV9iXs1b8mpNtG/wQ5Zy2VrG+PLgAeZQRrG+fGr2gn2mtoqyyZxqaX0 X-Received: by 2002:a17:902:a5c5:: with SMTP id t5-v6mr29788187plq.6.1537284583348; Tue, 18 Sep 2018 08:29:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537284583; cv=none; d=google.com; s=arc-20160816; b=fNliZOb9fcehDjcy2gOWCPrG0uXbq8V7WPDxi+4xEyynTKx7XgbFi4Z3XW9Di245pH LNMBj2EORZt+A7rMabsC7yPTTIfhcE+7NqkOc1nf3qPyVoX87PGwmXcG6pE3ckcKvVwJ 7W4+d3LXTwYpmdldjRSdlD4AJt/A7+fRqOwwuq3e2FGUTgdNpAG1Owp73yfqhloacjNj b2Ylx3N+Uo/f84UHdJCZaWvurd+4NVxJRMotpJrkOIpDn6CYT+jf1i7GuTh+aSV2Mygg dDNZ3uNS0YsI1h3JrKtK6XgwWEX0DUUtN7nGv7TlBMttUtqRlosjnxT6DMbXZo9/JuTp 3gGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization; bh=5KHPSaRAZcAtdD6MUgz1CHqgwfDXUl8l13ZYj+zhlzE=; b=nN4QZR/ANY/qRmdO1zuFv0SyfAmxFpOZRvZanNZDv0qyHYvPhxmP7HvYAzZoZ2M0jz mLdxu60V1FU7pEj9JoyRLC6dwdvj8DPu3DO+AHrC8lzndh2cJPdU6fb5YDSkJYnPxrWK kx489QUXywuTIJDUBitXjiac/vrwci0TNBkQHkoAjZWQJPJ7kSuhdtMaBiKbydrbQtO4 X6gN0m1+poV/HOAP3ftRIS39ae4F4kePt99NQaVOKaKnnzhlmc+RrTyGRd3bwiUbcExx 7ya8wrvXcE45Q6MfBcjOi0aC0rWgHXRhpY7cgiyPSz6/RTktKdhcIY1JLvEd3ZicHzJR Mp/Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g15-v6si18262130plo.284.2018.09.18.08.29.27; Tue, 18 Sep 2018 08:29:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729882AbeIRVBo (ORCPT + 99 others); Tue, 18 Sep 2018 17:01:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59158 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729447AbeIRVBo (ORCPT ); Tue, 18 Sep 2018 17:01:44 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9C5173084041; Tue, 18 Sep 2018 15:28:40 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-123-84.rdu2.redhat.com [10.10.123.84]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6CFAB18FCA; Tue, 18 Sep 2018 15:28:39 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20180918095437.GB417@jagdpanzerIV> References: <20180918095437.GB417@jagdpanzerIV> <153313703562.13253.5766498657900728120.stgit@warthog.procyon.org.uk> <153313714181.13253.304098108512966976.stgit@warthog.procyon.org.uk> To: Sergey Senozhatsky Cc: dhowells@redhat.com, viro@zeniv.linux.org.uk, torvalds@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/33] vfs: Implement a filesystem superblock creation/configuration context [ver #11] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <22687.1537284518.1@warthog.procyon.org.uk> Date: Tue, 18 Sep 2018 16:28:38 +0100 Message-ID: <22688.1537284518@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Tue, 18 Sep 2018 15:28:40 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sergey Senozhatsky wrote: > > + err = security_fs_context_validate(fc); > > + if (err) > > + return err; > > goto err_fc? Fixed thanks. > > + } else { > > + err = security_sb_remount(sb, data, data_size); > > + if (err) > > + return err; > > + } > > goto err_fc? This no longer exists. I need to repost my patchset. I was hoping to fix the mqueue bug there first, though, but maybe I should just post anyway. David