Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp5480994imm; Tue, 18 Sep 2018 10:10:04 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbIeTypYeRWVdCQIzkUFqoN3dfO+EdGQAPAnHfd54KYPyq3/PkvjvTAyc10/zpn78ZWwVLn X-Received: by 2002:a17:902:8348:: with SMTP id z8-v6mr30789151pln.51.1537290604877; Tue, 18 Sep 2018 10:10:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537290604; cv=none; d=google.com; s=arc-20160816; b=OsUUcSy7qjA0gYecCIk5xSIJ4tYpubR8slQ1mMIaaj9tMFuQ+kTE+LVoX/VP4BM8LA mQGD9ILncX/cK7mZXqUVwLv80f1Di+lILlyyHsc58urwGFF++9Mjs2UNC9chg6MmqE6F O7L3z1zUTXMCMGa3aQdNGFyMaq9b554XtvcXyrD5VNuYCy6obNgH2kWEpZk5lVMsNN4v Ita6z8oGu6IyMuo93yiR0gP8KkQGuMpbO+plSXF/XV9TYPOOS867ve3X37imtYtsIvfh yoyMft1e8gDrawmuyVEXUxNCBDUIUkVfqcRufNEyKM+sFicUE4yMzZeK2p9LLkChC8Ha i+7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=HNlo3xyc6igs5gw6PG6FCqhsrp4IMHY7I7PXOCtKR3g=; b=tsSaAQ7a5SglcjQwL4A5cmyWRIS00G8PKp6kDdFjddIbepLxL3EAYMESrUHMW10vII 34djGtZb1d6190iGwvI2ceNUSHHqY5MN9dkFChuiAD9YOEN0Hi7U8taGaXs6U2NzRBcO hEZtGz0XRh5wd8R+IyPOgkohsCHUwV+2ICV5cYTOIno9CFhJfmVA88+h2bgT1IhfAkaI LPJX6qsl8e7UhveIQJrK0AgPnocWR8FPBeZNq+4in4DSMXFTP3N0DHORnT8gPzCl6Trw ctYP7gm8T2qUBt9xQEZ67UsnUcIHsfuXgYQXghhaN6ZGNhSAOKrZ7ZU5SuR67vRKPz4t NnZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@lechnology.com header.s=default header.b=Ua57QojD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v9-v6si20017074pfg.123.2018.09.18.10.09.49; Tue, 18 Sep 2018 10:10:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@lechnology.com header.s=default header.b=Ua57QojD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730482AbeIRWnH (ORCPT + 99 others); Tue, 18 Sep 2018 18:43:07 -0400 Received: from vern.gendns.com ([206.190.152.46]:51325 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730373AbeIRWnF (ORCPT ); Tue, 18 Sep 2018 18:43:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lechnology.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject :Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=HNlo3xyc6igs5gw6PG6FCqhsrp4IMHY7I7PXOCtKR3g=; b=Ua57QojDERr54TiQFBWLH0OdD NdeJcidJ0dWq4phGknkyjTLsj+rqDYXxsqZnioD44B8RoD41Cb22ZtEcj7LEQEUO68ETndSc0/Qsm jer2L88MK2E/dR2gOgf6A8Prcv2sZTRCm5YN953oh3Mzh8RsDknjSCUHXcvIeVyCb3cgGcDuJl1Ze fq3k0pB9vvhOQxLtyjuEd0S+qZdXCCbpNgx1j5EOoFaLaGaSYN2HZhqG0b88wybHCiERFSLa3NL/5 Z/SEyn0ngJzJYe/OQiMWJ6DUQUe32lmfbe5HfLRHT1uRb05owaCDrSnJE08SVitNfmSAM/SkYU4Ao YU65gLEoA==; Received: from 108-198-5-147.lightspeed.okcbok.sbcglobal.net ([108.198.5.147]:37876 helo=freyr.lechnology.com) by vern.gendns.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1g2JVD-0074xZ-53; Tue, 18 Sep 2018 13:09:31 -0400 From: David Lechner To: linux-spi@vger.kernel.org, linux-iio@vger.kernel.org Cc: David Lechner , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Mark Brown , Geert Uytterhoeven , linux-kernel@vger.kernel.org Subject: [PATCH 2/3] spi: spi-davinci: Don't error when SPI_CS_WORD and cs_gpio Date: Tue, 18 Sep 2018 12:08:49 -0500 Message-Id: <20180918170850.2749-3-david@lechnology.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180918170850.2749-1-david@lechnology.com> References: <20180918170850.2749-1-david@lechnology.com> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This remove the check and subsequent return of error for the case when a SPI device requires SPI_CS_WORD and is also configured to use a GPIO for the CS line. Commit a134cc414e86 ("spi: always use software fallback for SPI_CS_WORD when using cs_gio") handles this case now, so this check is no longer necessary. Signed-off-by: David Lechner --- drivers/spi/spi-davinci.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c index 205f763c7383..56adec83f8fc 100644 --- a/drivers/spi/spi-davinci.c +++ b/drivers/spi/spi-davinci.c @@ -441,9 +441,6 @@ static int davinci_spi_setup(struct spi_device *spi) if (internal_cs) { set_io_bits(dspi->base + SPIPC0, 1 << spi->chip_select); - } else if (spi->mode & SPI_CS_WORD) { - dev_err(&spi->dev, "SPI_CS_WORD can't be use with GPIO CS\n"); - return -EINVAL; } } -- 2.17.1