Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp5519967imm; Tue, 18 Sep 2018 10:47:08 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZidBYIHm8XY0sAjcvAO/9iY+o1izSJFlCuZ3VsE2UXDdLBfaJN2j8fww5dpv81eePFaA2I X-Received: by 2002:a17:902:6e01:: with SMTP id u1-v6mr31007551plk.13.1537292828392; Tue, 18 Sep 2018 10:47:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537292828; cv=none; d=google.com; s=arc-20160816; b=aJTHROHNKbxPi1coIJH8ld9dxUr8vFq5D6e/hhpiMToMkIyu3Km240ANcmUIDARqJ4 Pe7muxptKTtLXikDXe06BicbwLU8ixTWDF8RtkoArEBOFRUs7Xubwcx1GmJm1C5FB7F5 CRdwf86VTTg2iWzUeE4Y65uz7FRrCygv3Gc59nkpYEpISozgawTfabSjBgO0OTr03F5G HAk05tiVnUFYbZegVuSoVgRzwOp6TqRWBaVNBJvXXoGSa8BZhWwbVvxbj4AihYvGP3cf XTUzwgtvBohB3dENVXHaJ0XQ12GZ/yfFmaMrOcOAy7jfhTrGvhCiD9rM2OScBc5gJ3Pr KLwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=zKI4Kj4ahwadqOUaI8J707VCqYsUn2Mkh5071Zvum6w=; b=HJs4YRInXcz9gPzMGTtLKs7g9EKjnNrh2U3Np7Fd92UCqC14lHhaM60ewxvW+fZjwc pinT5rJoM2nUGj0y112KJQfZ9NjwCl1L0ijzDsgvMHZyOlR/Pn/rRh8YDlAVjsV5/yU2 I3vIdCmLy3C1PqTsOg9n2HvntmE96tliGDdjHr6muNIxNNI6ON52R5a7yHjaOwTX2Lgq 1W9ERq+3+2c/wEYWAUJCIWHhCrP01Bmu+8e+//+RXrbOwxHHGo3WOTTU42tJkeWXAVUt mIEeQk469ySKaHCtEkoxB2bUzoHZ1BkMXZlB1jN1Oi7rWI2g7Y2P73MQtkBQZmB61os4 /5nA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=J4B6PPoC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j13-v6si14581866pgf.609.2018.09.18.10.46.45; Tue, 18 Sep 2018 10:47:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=J4B6PPoC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730439AbeIRXUD (ORCPT + 99 others); Tue, 18 Sep 2018 19:20:03 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:34304 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729928AbeIRXUD (ORCPT ); Tue, 18 Sep 2018 19:20:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=zKI4Kj4ahwadqOUaI8J707VCqYsUn2Mkh5071Zvum6w=; b=J4B6PPoCyBxf a+ZYtaNkByZBC1TDo/apu7ZOjWyAZkzQkN8eOmMdVqRB+es1BTT3qn6PzflXXBxr+Y9A1fx8uKmv2 7/HRxJ3KxQRyKELtGvZAr2toJKsXt4YjdmXMq8ZON6TIH/+nQAy05GJm76ybeU2oTq/F5M1YeXAOB Dywj4=; Received: from [209.121.128.187] (helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1g2K4N-0003XN-Oh; Tue, 18 Sep 2018 17:45:52 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id DE9B4440078; Tue, 18 Sep 2018 18:45:49 +0100 (BST) From: Mark Brown To: David Lechner Cc: Mark Brown , linux-spi@vger.kernel.org, linux-iio@vger.kernel.org, Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Mark Brown , Geert Uytterhoeven , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Subject: Applied "spi: spi-davinci: Don't error when SPI_CS_WORD and cs_gpio" to the spi tree In-Reply-To: <20180918170850.2749-3-david@lechnology.com> Message-Id: <20180918174549.DE9B4440078@finisterre.ee.mobilebroadband> Date: Tue, 18 Sep 2018 18:45:49 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch spi: spi-davinci: Don't error when SPI_CS_WORD and cs_gpio has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From f34ecdbd5661816ce8bbd7511f33181ffa8f4895 Mon Sep 17 00:00:00 2001 From: David Lechner Date: Tue, 18 Sep 2018 12:08:49 -0500 Subject: [PATCH] spi: spi-davinci: Don't error when SPI_CS_WORD and cs_gpio This remove the check and subsequent return of error for the case when a SPI device requires SPI_CS_WORD and is also configured to use a GPIO for the CS line. Commit a134cc414e86 ("spi: always use software fallback for SPI_CS_WORD when using cs_gio") handles this case now, so this check is no longer necessary. Signed-off-by: David Lechner Signed-off-by: Mark Brown --- drivers/spi/spi-davinci.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c index 205f763c7383..56adec83f8fc 100644 --- a/drivers/spi/spi-davinci.c +++ b/drivers/spi/spi-davinci.c @@ -441,9 +441,6 @@ static int davinci_spi_setup(struct spi_device *spi) if (internal_cs) { set_io_bits(dspi->base + SPIPC0, 1 << spi->chip_select); - } else if (spi->mode & SPI_CS_WORD) { - dev_err(&spi->dev, "SPI_CS_WORD can't be use with GPIO CS\n"); - return -EINVAL; } } -- 2.19.0