Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Songxiaowei (Kirin_DRV)" <songxiaowei@hisilicon.com>
To:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        kbuild test robot <fengguang.wu@intel.com>,
        "Wangbinghui (Biggio, Kirin_DRV)" <wangbinghui@hisilicon.com>
CC:     Shawn Lin <shawn.lin@rock-chips.com>,
        "kbuild-all@01.org" <kbuild-all@01.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <helgaas@kernel.org>
Subject: RE: [PATCH] PCI: fix ptr_ret.cocci warnings
Thread-Topic: [PATCH] PCI: fix ptr_ret.cocci warnings
Thread-Index: AQHUT1rooSgHLqeFvkqN7xyKYxgBgKT2w/9g
Date:   Wed, 19 Sep 2018 00:40:55 +0000
Message-ID: <99B4C6BADD9E3241B25E52B02BA737C541375D26@dggema525-mbx.china.huawei.com>
References: <201807200739.O5DHU6D3%fengguang.wu@intel.com>
 <20180719234243.GA4239@athens>
 <20180918142122.GB32243@e107981-ln.cambridge.arm.com>
In-Reply-To: <20180918142122.GB32243@e107981-ln.cambridge.arm.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

That's OK, and thank a lot.

> -----Original Message-----
> From: Lorenzo Pieralisi [mailto:lorenzo.pieralisi@arm.com]
> Sent: Tuesday, September 18, 2018 10:21 PM
> To: kbuild test robot <fengguang.wu@intel.com>; Songxiaowei (Kirin_DRV)
> <songxiaowei@hisilicon.com>; Wangbinghui (Biggio, Kirin_DRV)
> <wangbinghui@hisilicon.com>
> Cc: Shawn Lin <shawn.lin@rock-chips.com>; kbuild-all@01.org;
> linux-kernel@vger.kernel.org; Bjorn Helgaas <helgaas@kernel.org>
> Subject: Re: [PATCH] PCI: fix ptr_ret.cocci warnings
> 
> On Fri, Jul 20, 2018 at 07:42:43AM +0800, kbuild test robot wrote:
> > From: kbuild test robot <fengguang.wu@intel.com>
> >
> > drivers/pci/controller/dwc/pcie-kirin.c:141:1-3: WARNING:
> > PTR_ERR_OR_ZERO can be used
> > drivers/pci/controller/dwc/pcie-kirin.c:177:1-3: WARNING:
> > PTR_ERR_OR_ZERO can be used
> >
> >
> >  Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> >
> > Generated by: scripts/coccinelle/api/ptr_ret.cocci
> >
> > Fixes: 6e0832fa432e ("PCI: Collect all native drivers under
> > drivers/pci/controller/")
> > CC: Shawn Lin <shawn.lin@rock-chips.com>
> > Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
> > ---
> >
> >  pcie-kirin.c |   10 ++--------
> >  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> Xiaowei, Binghui,
> 
> are you OK with this change ? I will remove the Fixes: tag from the patch.
> 
> Let me know, thanks.
> 
> Lorenzo
> 
> > --- a/drivers/pci/controller/dwc/pcie-kirin.c
> > +++ b/drivers/pci/controller/dwc/pcie-kirin.c
> > @@ -138,10 +138,7 @@ static long kirin_pcie_get_clk(struct ki
> >  		return PTR_ERR(kirin_pcie->apb_sys_clk);
> >
> >  	kirin_pcie->pcie_aclk = devm_clk_get(dev, "pcie_aclk");
> > -	if (IS_ERR(kirin_pcie->pcie_aclk))
> > -		return PTR_ERR(kirin_pcie->pcie_aclk);
> > -
> > -	return 0;
> > +	return PTR_ERR_OR_ZERO(kirin_pcie->pcie_aclk);
> >  }
> >
> >  static long kirin_pcie_get_resource(struct kirin_pcie *kirin_pcie, @@
> > -174,10 +171,7 @@ static long kirin_pcie_get_resource(stru
> >
> >  	kirin_pcie->sysctrl =
> >  		syscon_regmap_lookup_by_compatible("hisilicon,hi3660-sctrl");
> > -	if (IS_ERR(kirin_pcie->sysctrl))
> > -		return PTR_ERR(kirin_pcie->sysctrl);
> > -
> > -	return 0;
> > +	return PTR_ERR_OR_ZERO(kirin_pcie->sysctrl);
> >  }
> >
> >  static int kirin_pcie_phy_init(struct kirin_pcie *kirin_pcie)