Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp203124imm; Tue, 18 Sep 2018 20:02:14 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdbi6OtAG2xspAmT/jW59LLXFRPBjQXpL/pZIoZ6zzekpG3/V1E7lHxQp2K7OFn8NP6kk7ei X-Received: by 2002:a62:2a48:: with SMTP id q69-v6mr33598958pfq.86.1537326134403; Tue, 18 Sep 2018 20:02:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537326134; cv=none; d=google.com; s=arc-20160816; b=hZyfBaM+VHoSg9lJ4xIzJTAqqUvkl9osoyh+TfXOfw6vxOFuMdtn3YNPxHv0KuQSNJ u1fuM+znAQsxP+CSfcq8F49PPrpkatTHU4mSZrJXStN3LcXRjyj3Wr+NlkRelYwDkbag tZ7Y9iAOVFsDh6fzYsjhm4ND4zJB13kWGoLs2mxenoDuk9qAvO68ixUKPXNycGi2TQo0 tHUfLOJlan/uiLTrSGr4kC8U96foR48Hc57veXY7rcAPpj5CvUkXWMA7ixnllQmYCVSe aLKH2S1niwZzIiD8h/XC34hU4sB99G/AMpLKHQNXegGSBCn2uRC5MbpculhBC83ISL6S Km1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=QByR5ydVLtKmU5pEuVKPJt1dXze8UbawV44Yjy1fFDs=; b=cEcHJIhho0rPdhhg+DON69uaozVCEYXmq3XK74u1TNe+Qw5/5kyh3eywcqg2hM2Nul 9MKYI+h+5mWIp8I2qoLSMoNu5GMq0CTGRZrh8GlhwDso4rztXm5TdqMTrQOqlK3k7JFa 9quQIl6TBT1Z7E1ZpOzRPOO2vGlBGhLz27EsygbGOFrMRola8meBESUGjDS/XHBNQMQy XWcZ17D1pXGZNT/JXAK5pFWQyEaFNjQ8MThXjo+/r9pW4QTShogGkvlgCNK2llbx8Zpe J5bCfmklUsDhwgII/0SB13jb2fTG8DGjytlJECKrUhyaWkxnHUvGoWecO93k+AAM95XX arww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d11-v6si21204653pla.245.2018.09.18.20.01.58; Tue, 18 Sep 2018 20:02:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727822AbeISIhf (ORCPT + 99 others); Wed, 19 Sep 2018 04:37:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50786 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725817AbeISIhf (ORCPT ); Wed, 19 Sep 2018 04:37:35 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 20FD13D09; Wed, 19 Sep 2018 03:01:51 +0000 (UTC) Received: from localhost (ovpn-112-7.rdu2.redhat.com [10.10.112.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 47241608E5; Wed, 19 Sep 2018 03:01:48 +0000 (UTC) Date: Tue, 18 Sep 2018 20:01:47 -0700 (PDT) Message-Id: <20180918.200147.1974460297125412298.davem@redhat.com> To: yuehaibing@huawei.com Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next] net: hns3: fix return type of ndo_start_xmit function From: David Miller In-Reply-To: <20180918060943.25208-1-yuehaibing@huawei.com> References: <20180918060943.25208-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 19 Sep 2018 03:01:51 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing Date: Tue, 18 Sep 2018 14:09:43 +0800 > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, also the implementation in this > driver has returns 'netdev_tx_t' value, so just change the function > return type to netdev_tx_t. > > Found by coccinelle. > > Signed-off-by: YueHaibing Applied.