Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp204303imm; Tue, 18 Sep 2018 20:03:43 -0700 (PDT) X-Google-Smtp-Source: ANB0Vda7bfR9TWBXVZB0SRwJ3VmfMF/sOXXWc3wO6Mq4VbgBlvm2EKNq4HtCo7vACgJ7UOdz2R77 X-Received: by 2002:a17:902:6b83:: with SMTP id p3-v6mr32322419plk.133.1537326223306; Tue, 18 Sep 2018 20:03:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537326223; cv=none; d=google.com; s=arc-20160816; b=W5fhc/cAAF7NCQzMrR/yJrEHQ5OblygDp2sDSrXQPxelpktYzUH/wJ2f9BGxWM1cVO TvQxUSNhrA/mtB0mTtdKIq7aRf6F/Vx0RB53xKbVsodek0JXc/vS76Azgt5zdmG1GOok 6WftMfuYOqCF5YhX8c3y1il6lKBl9Gxazf2szvo0oP23C01xlmUxsSSHJ/v2B+WjrXyJ 3dRbOlStkN7C8VMcONnlpNTumfkISjNoJZMTD3ozYbwHzm/qV5HW82kPptHzH37Mx0ft Z46UakWXXZg+eTGN9Fn1miAvb9sqC6jNLY8JX6DJDCsD/7vkt0ufVu1jzlxmVEEoLdtp P4Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=XFyw2pKhLo0wlwD/ZuZCM8UK8HhWE+yWcy0fh3VSY6o=; b=xjK/1oAmJA5ucT/UEi2uBFqxCKWBt+2k3WFFp36zz3vlNkkqSfkSn9+7D7UKpo3k7w wgRDOu/wLQnNGJMgTq1jeXUrHuQIeRnk3BOezE9XW0TafeDZzCjoCJEsjiPIqhclI9QO DATKHSMRu4w2pYWGOdun5UsyDe1Fj5LRd43T7gIDuGF9byeVkv9bj9WcGhsWjSHgAKku VnnGkTWL65J2j2rWnN7ZOnura+4lTn83B0JjBYAP9/nmKe3XJWUOnreGg1322a9zt4ng QEwHj+f830iBM2FqQZULB13kZFmvScmmunZLwNZjK24ETUt08z6r6QwXiHhqthZrIzyJ H6Cw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u6-v6si20908928pfu.143.2018.09.18.20.03.27; Tue, 18 Sep 2018 20:03:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728249AbeISIjD (ORCPT + 99 others); Wed, 19 Sep 2018 04:39:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56182 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725817AbeISIjD (ORCPT ); Wed, 19 Sep 2018 04:39:03 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ED495C047B69; Wed, 19 Sep 2018 03:03:18 +0000 (UTC) Received: from localhost (ovpn-112-7.rdu2.redhat.com [10.10.112.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id ED51C82AE8; Wed, 19 Sep 2018 03:03:15 +0000 (UTC) Date: Tue, 18 Sep 2018 20:03:14 -0700 (PDT) Message-Id: <20180918.200314.172763067668053603.davem@redhat.com> To: yuehaibing@huawei.com Cc: derek.chickles@caviumnetworks.com, satananda.burla@caviumnetworks.com, felix.manlunas@caviumnetworks.com, raghu.vatsavayi@caviumnetworks.com, alexander.sverdlin@nsn.com, david.daney@cavium.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next] net: cavium: fix return type of ndo_start_xmit function From: David Miller In-Reply-To: <20180918061905.25000-1-yuehaibing@huawei.com> References: <20180918061905.25000-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 19 Sep 2018 03:03:19 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing Date: Tue, 18 Sep 2018 14:19:05 +0800 > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, so make sure the implementation in > this driver has returns 'netdev_tx_t' value, and change the function > return type to netdev_tx_t. > > Found by coccinelle. > > Signed-off-by: YueHaibing Applied.