Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp205417imm; Tue, 18 Sep 2018 20:05:00 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbgL2IB5HutjpOo77rdwsV9lYai+RMOAO7tVWC2JR+QfouMzkv3ec+4fBzD1B1sCgEZ4DvS X-Received: by 2002:a63:e355:: with SMTP id o21-v6mr30787415pgj.251.1537326300914; Tue, 18 Sep 2018 20:05:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537326300; cv=none; d=google.com; s=arc-20160816; b=vpvkjse/TBFqLfacyOx7+zNWltuQn6Giec9eoBGxME8lzzKqKh2WrahnbYfv7keIIl UgC7A+ry0r2V3ROtYhUus859jnspDlSTI5SKd3o1e9/D480hU6qKcurc9XL9hVnAvOdH RrUWiaarNyh0AzArwdfIZeQ+Bl8kN6IPY+as96mJties6O9qTHIWgYL094CIq0WZHZNc DCEthGYPIP5Jp5z4ggwDCiYKo+euCM5b+jOhkBIiRi9velQO2KxHAYHwHOocqyNn7SgV AiitziiBS/lz2qg35BsO8Y870t94cGA2cS1DgwPzElQnELqpDMTfUfbK7svwIPuTD4/a 19OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=abQ5zNNUzllrcT8rkU9KcKJzLWgW96NDYAnFXZ3FEKk=; b=f54lWfk4Ox6b3hUEJOMUstIxR+HeZAevRGqL6B/FpU07ApsBXywmwGX8Nw1hGa3iA6 LeSR5hVTStBYeoxk6opsYq5gOiLv9w8BwZbGPZpX4vFB87CH3GbXwsjbPF/CkTrPaQw3 HXX7lJkzJRvo8ZInSFzFf3ZNG+esnMscAeo3CgQ/3vBMcIvvmJVAKXZg8Yi1zV5bJA0+ n9WDPgVf/KP72tkerp/ZzbYTnLzjYg/0omLpYpY/f70QCXLRhtoqhPEsKY1e4hsHPdch 2j650SC6u8H6ATMt+9IG16vtPpDb398jvCMxNoyppLkfEXT+YGX6VjmMAmvw5FTQ5Zqs GwPw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h89-v6si19819559pld.517.2018.09.18.20.04.44; Tue, 18 Sep 2018 20:05:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730325AbeISIjm (ORCPT + 99 others); Wed, 19 Sep 2018 04:39:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39532 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725817AbeISIjm (ORCPT ); Wed, 19 Sep 2018 04:39:42 -0400 Received: from smtp.corp.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2FE7283F42; Wed, 19 Sep 2018 03:03:56 +0000 (UTC) Received: from localhost (ovpn-112-7.rdu2.redhat.com [10.10.112.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id EC10730912F4; Wed, 19 Sep 2018 03:03:50 +0000 (UTC) Date: Tue, 18 Sep 2018 20:03:49 -0700 (PDT) Message-Id: <20180918.200349.177775356017382984.davem@redhat.com> To: yuehaibing@huawei.com Cc: dougmill@linux.vnet.ibm.com, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, tlfalcon@linux.vnet.ibm.com, jallen@linux.vnet.ibm.com, ivan@de.ibm.com, chunkeey@gmail.com, keescook@chromium.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH net-next] net: ibm: fix return type of ndo_start_xmit function From: David Miller In-Reply-To: <20180918063547.25644-1-yuehaibing@huawei.com> References: <20180918063547.25644-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 19 Sep 2018 03:03:57 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing Date: Tue, 18 Sep 2018 14:35:47 +0800 > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, so make sure the implementation in > this driver has returns 'netdev_tx_t' value, and change the function > return type to netdev_tx_t. > > Found by coccinelle. > > Signed-off-by: YueHaibing Applied.