Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 18 Sep 2018 23:05:37 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc:     He Zhe <zhe.he@windriver.com>, pmladek@suse.com,
        sergey.senozhatsky@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] printk: Fix panic caused by passing log_buf_len
 to command line
Message-ID: <20180918230537.30448bd7@vmware.local.home>
In-Reply-To: <20180919024754.GA15128@jagdpanzerIV>
References: <1537291068-443145-1-git-send-email-zhe.he@windriver.com>
        <20180919015030.GA423@jagdpanzerIV>
        <6c354803-5341-7237-9ee3-7882252c7483@windriver.com>
        <20180919023932.GA14090@jagdpanzerIV>
        <20180918224312.6e9aef50@vmware.local.home>
        <20180919024754.GA15128@jagdpanzerIV>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 19 Sep 2018 11:47:54 +0900
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> wrote:

> On (09/18/18 22:43), Steven Rostedt wrote:
> > >  First  - switch to u64 size.
> > >  Second - check for NULL str.
> > >   
> > I think I would switch it around. Check for NULL first, and then switch
> > to u64. It was always an int, do we need to backport converting it to
> > u64 to stable? The NULL check is a definite, the overflow of int
> > shouldn't crash anything.  
> 
> Agreed. This order makes much more sense. Do you mind, tho, to have
> "unsigned int size" in the first patch along with NULL str check?
> Just to silent the checkpatch.
> 

I guess that doesn't hurt. I'd personally would keep it separate (just
fix what's broken), but it's such a slight change, I don't have any
strong feelings about it.

Thanks,


-- Steve