Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] staging: erofs: Fix a unused variable 'arg' warning
To:     zhong jiang <zhongjiang@huawei.com>, gregkh@linuxfoundation.org
Cc:     gaoxiang25@huawei.com, yuchao0@huawei.com,
        linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org
References: <1537323381-23839-1-git-send-email-zhongjiang@huawei.com>
From:   cgxu519 <cgxu519@gmx.com>
Message-ID: <5b3438ac-f4d4-7f66-4be0-1720c1eada98@gmx.com>
Date:   Wed, 19 Sep 2018 11:07:17 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <1537323381-23839-1-git-send-email-zhongjiang@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 09/19/2018 10:16 AM, zhong jiang wrote:
> I find the following warning when compiling the kernel.
>
> drivers/staging/erofs/super.c:195:6: warning: unused variable 'arg' [-Wunused-variable]
>    int arg = 0;
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
>   drivers/staging/erofs/super.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/erofs/super.c b/drivers/staging/erofs/super.c
> index 6423592..c04313f 100644
> --- a/drivers/staging/erofs/super.c
> +++ b/drivers/staging/erofs/super.c
> @@ -192,7 +192,9 @@ static int parse_options(struct super_block *sb, char *options)
>   {
>   	substring_t args[MAX_OPT_ARGS];
>   	char *p;
> +#ifdef CONFIG_EROFS_FAULT_INJECTION
>   	int arg = 0;
> +#endif
>   
>   	if (!options)
>   		return 0;

Hi,

The fix has already included in my patch series "staging: erofs: option 
validation for remount and some code cleanups",
so it will be fixed when the series merge into tree and we do not 
encourage surrounding the code with macro in option
parsing for this case.

Thanks,
Chengguang