Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180918230002.GA7572@WindFlash>
References: <20180918230002.GA7572@WindFlash>
From:   Masahiro Yamada <yamada.masahiro@socionext.com>
Date:   Wed, 19 Sep 2018 16:10:41 +0900
Message-ID: <CAK7LNASCai6rPV-ibbKKzm94pr=5Ku_K3r1LY80BGngJWU73FQ@mail.gmail.com>
Subject: Re: [PATCH 1/1] kbuild: Optimize tests and remove shadowed local variable.
To:     David Howells <dhowells@redhat.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        =?UTF-8?Q?Leonardo_Br=C3=A1s?= <leobras.c@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

FW: David Howells


2018-09-19 8:00 GMT+09:00 Leonardo Br=C3=A1s <leobras.c@gmail.com>:
> Removes an unnecessary shadowed local variable (start).
> Optimize test of isdigit:
> - If isalpha returns true, isdigit will return false, so no need to test.
>
> Signed-off-by: Leonardo Br=C3=A1s <leobras.c@gmail.com>


This patch was sent to me, but maybe belong to David's field.

David, will you take care of this patch?

https://lore.kernel.org/patchwork/patch/988171/

I think the commit subject should be changed kbuild: -> ASN.1:


Anyway, this patch looks trivial,
FWIW

Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>


> ---
>  scripts/asn1_compiler.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/asn1_compiler.c b/scripts/asn1_compiler.c
> index c146020fc783..a0056df4e358 100644
> --- a/scripts/asn1_compiler.c
> +++ b/scripts/asn1_compiler.c
> @@ -413,7 +413,7 @@ static void tokenise(char *buffer, char *end)
>
>                         /* Handle string tokens */
>                         if (isalpha(*p)) {
> -                               const char **dir, *start =3D p;
> +                               const char **dir;
>
>                                 /* Can be a directive, type name or eleme=
nt
>                                  * name.  Find the end of the name.
> @@ -454,10 +454,10 @@ static void tokenise(char *buffer, char *end)
>
>                                 tokens[tix++].token_type =3D TOKEN_TYPE_N=
AME;
>                                 continue;
> -                       }
>
> -                       /* Handle numbers */
> -                       if (isdigit(*p)) {
> +                       } else if (isdigit(*p)) {
> +                               /* Handle numbers */
> +
>                                 /* Find the end of the number */
>                                 q =3D p + 1;
>                                 while (q < nl && (isdigit(*q)))
> --
> 2.19.0
>


--=20
Best Regards
Masahiro Yamada