Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp497975imm; Wed, 19 Sep 2018 02:19:08 -0700 (PDT) X-Google-Smtp-Source: ANB0VdY6e+0v5Isfyxchk8wVv9oHFbe23z4IyeNOqcImzd7gNYaGpuTT8ncNbLlGRGkpHtuE42hc X-Received: by 2002:a62:6602:: with SMTP id a2-v6mr35423152pfc.159.1537348748108; Wed, 19 Sep 2018 02:19:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537348748; cv=none; d=google.com; s=arc-20160816; b=Pn/dYxzwognD2cDovTNeibWvqwYerHtP1y5P+QZ/KxfOnqvBupraZ+8XhBn1o/uSh6 9uY5dNDlzJen6ViC64g9frIKNKZcIRp883H3iJqZBTUZ9VveO3GHXYtiU/wxC1dzhdgr RkY9CUUSih2cSF0OO9PhGFVcdCJFmO0MB6Lzo4jdAELgYbBevgj6JaukmCyazQevv0/n JZdMMKtPNtIZZYnOKYc3w+Gw5+YM6V6FTbzI7kF6IIzQ2Q9gtKg/EhSkjv+op1DykUMb 5RHvqYHe23wNsZYwhEefVec2BzQ07qCDObJG2rm7hLt98M/PsHIPVnQ55Y4WRsiqNWI4 4osA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=CPiSAyjpLKLvbxDMWSmiLwt9Aqv24WsOPZ4mNRHz7O8=; b=gnxaP0BBH1RIP6V9JOTYM9qPnBz4+M1MSDpe4P90kHgFsMXKJGWs/FJTWUcbIBGjC/ IYayohXW2YWl3lVySEh+IVNLeGlksopzEs8gwr27nW1E+5KRDRN/cibgCEdxkaFcN8Dn kFHvQidJ0GBKlI14+2AC2B7V+mvhwkzisIa7OFHey8xPtSucNvbX83nbe2bSXJfe8bPI 0ce853snJSeEa2sswfx86J6mT2cC7///wmgK+SNAPBHhJJqh2aZAYqQNutKm6iOL6m+6 yNX5BeryPDr88jITM9JfYMhULl4v0MothXpLWYDhfFYnncsRLUtQFRPcjCZI2HrQJZkF pMAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=YXuyrQHh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g20-v6si20444724pgb.239.2018.09.19.02.18.51; Wed, 19 Sep 2018 02:19:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=YXuyrQHh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731031AbeISOzB (ORCPT + 99 others); Wed, 19 Sep 2018 10:55:01 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:40768 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727056AbeISOzB (ORCPT ); Wed, 19 Sep 2018 10:55:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=CPiSAyjpLKLvbxDMWSmiLwt9Aqv24WsOPZ4mNRHz7O8=; b=YXuyrQHhbDDXAufRolije9mFl yeOLWS1x80zLjpcotvboug5uGPx8TBQSJJaZBt60WEcasVGtWYb4DPvVZN85I9wUUWIWmpnDgfkz2 VLHmc6IbxzuGcgbJZ8zWfkeMgXrpIu/1Hv1HgQHI8kQ6lkBU6fYUL993zkGTMhl2hg8wzarqiacR1 NASQ6FR62pBT/InCV7TZs3K4pYp/7BHpndzknLymISjmme4UJMl+l6IJfUPk9M3fvhu1mOBBYD6/R vH+JgBr4dV4pmkE5iaRtuqNKlW98jb3LoQnY6x2ZED9Ug2m9Fr5TXwe4axyueUOfJ4Sho8aENj41y CS8K2iKlA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1g2YcT-0005Qd-2P; Wed, 19 Sep 2018 09:18:01 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 99835202C1A33; Wed, 19 Sep 2018 11:17:59 +0200 (CEST) Date: Wed, 19 Sep 2018 11:17:59 +0200 From: Peter Zijlstra To: Reinette Chatre Cc: tglx@linutronix.de, fenghua.yu@intel.com, tony.luck@intel.com, mingo@redhat.com, acme@kernel.org, gavin.hindman@intel.com, jithu.joseph@intel.com, dave.hansen@intel.com, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3 2/6] perf/core: Add helper to obtain performance counter index Message-ID: <20180919091759.GZ24124@hirez.programming.kicks-ass.net> References: <6f93048a74c66a275f8eb6e1298f10552d1e5d95.1536685533.git.reinette.chatre@intel.com> <20180917082336.GP24124@hirez.programming.kicks-ass.net> <20180917230758.GA3117@worktop.programming.kicks-ass.net> <07d81d39-6f78-7a07-099c-883c65b540e6@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <07d81d39-6f78-7a07-099c-883c65b540e6@intel.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 18, 2018 at 10:54:28AM -0700, Reinette Chatre wrote: > It works, but checkpatch.pl does not like it very much: > > CHECK: extern prototypes should be avoided in .h files > > #66: FILE: arch/x86/include/asm/perf_event.h:273: > > +extern int x86_perf_rdpmc_index(struct perf_event *event); Checkpatch is wrong. Ignore it.