Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp543212imm; Wed, 19 Sep 2018 03:10:33 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYSP6/mwKNk8gBY2gqfeRDsv7pkq9m5osHcmwDIeB29onSDreKDVpuIztKOIVHy069KwbbO X-Received: by 2002:aa7:8118:: with SMTP id b24-v6mr35584189pfi.78.1537351833296; Wed, 19 Sep 2018 03:10:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537351833; cv=none; d=google.com; s=arc-20160816; b=g9vj9MfwmGnzy7EPRRrhXQh+/FfjoyabnFZXXt1eib4QsN9jOxFLXfTwBI42MbTIyY E+pxxL9AaTcA9HZitm5c6SEZvKuXiy7rqdLOL8/b3/pA693LineDOrjPQCne/s5iFh3a 0VAf3P0NdKzlarqvrXf35pVMPUyLRDNYUoqqJ+3ofRtLAOBpaS4O74QJyWY2SmAJ5q9z MYduh1faHABbsxCYgv3nu+uXaqoCpgjShNzLALVdBVlaV64+Y7vbYxIrk+LM4I1KjVbX rVvB7oP3j0kYmQ0iZM0TAv8vfdz3YlQCWI8XEfTj3Eokvhk0RmZde5bDaNxHqPEgA8DW 4LEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=kLQMmWXG/+uz6+P+bKZrMfFFbwI3myW+p//cpHVx4lY=; b=ORiJZUMYNJMdMSAkjTffA5dBzy0W8RM3aAXxzoc2uEshRvj5PyqHeAR2i2u1kwB+EZ PNO5ojHxr6IBcTXNRjwbUERR4GEbtUoo/zXPVISPkpD6zDrQt6I4ThCvSKyKSmdx1KMi rEKzvRfgzuaDbjKMntO+0+ipE/thtuAg/p55mAtI+8XtUV2HBhXkL1FMDQvkC8m4VTyV oUkpxXrStw8UiLnRxXorJjSr5CDiCgBQttaXBjlmoFeETS3XUGoQOcuuaX1IOtg3+g5y mL5v9YZ6Ak2yppaJh2ViVL5ty1KN1ajeeBupBKXGyrZP06R6+9pVkKGFBxascEYFrdBO pwyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 137-v6si22968432pfx.155.2018.09.19.03.10.18; Wed, 19 Sep 2018 03:10:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731296AbeISPqy (ORCPT + 99 others); Wed, 19 Sep 2018 11:46:54 -0400 Received: from mail.windriver.com ([147.11.1.11]:36733 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728008AbeISPqy (ORCPT ); Wed, 19 Sep 2018 11:46:54 -0400 Received: from ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) by mail.windriver.com (8.15.2/8.15.1) with ESMTPS id w8JA9bE2018832 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 19 Sep 2018 03:09:37 -0700 (PDT) Received: from [128.224.162.216] (128.224.162.216) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 19 Sep 2018 03:09:36 -0700 Subject: Re: [PATCH v2 1/2] printk: Fix panic caused by passing log_buf_len to command line To: Sergey Senozhatsky , , CC: , References: <1537291068-443145-1-git-send-email-zhe.he@windriver.com> <20180919015030.GA423@jagdpanzerIV> <6c354803-5341-7237-9ee3-7882252c7483@windriver.com> <20180919064418.GC792@jagdpanzerIV> From: He Zhe Message-ID: Date: Wed, 19 Sep 2018 18:09:33 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180919064418.GC792@jagdpanzerIV> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [128.224.162.216] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018年09月19日 14:44, Sergey Senozhatsky wrote: > On (09/19/18 10:27), He Zhe wrote: >> On 2018年09月19日 09:50, Sergey Senozhatsky wrote: >>> On (09/19/18 01:17), zhe.he@windriver.com wrote: >>>> @@ -1048,7 +1048,14 @@ static void __init log_buf_len_update(unsigned size) >>>> /* save requested log_buf_len since it's too early to process it */ >>>> static int __init log_buf_len_setup(char *str) >>>> { >>>> - unsigned size = memparse(str, &str); >>>> + unsigned size; >>> unsigned int size; >> This is in v1 but then Steven suggested that it should be split out >> and only keep the pure fix part here. > JFI > > Seems there are more patches like this. I found this one in MM list: > lkml.kernel.org/r/1537284788-428784-1-git-send-email-zhe.he@windriver.com > > Andrew's response: > lkml.kernel.org/r/20180918141917.2cb16b01c122dbe1ead2f657@linux-foundation.org I just replied. Let's see what Andrew would say. https://lore.kernel.org/lkml/1c32c1d2-a54a-30f7-1afb-ad6d3282f54a@windriver.com/ Thanks, Zhe > > -ss >