Date: Fri, 14 Nov 2003 20:55:48 +0000 (GMT)
From: Tigran Aivazian <tigran@aivazian.fsnet.co.uk>
To: viro@parcelfarce.linux.theplanet.co.uk
cc: Harald Welte <laforge@netfilter.org>, <linux-kernel@vger.kernel.org>
Subject: Re: seq_file API strangeness
In-Reply-To: <20031114202327.GK24159@parcelfarce.linux.theplanet.co.uk>
Message-ID: <Pine.LNX.4.44.0311142048520.849-100000@einstein.homenet>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 978
Lines: 33

Hi Al,

On the same subject, but a different issue:

In the ->open() method I allocate a seq->private like this:

  err = seq_open(file, sop);
  if (!err) {
	struct seq_file *m = file->private_data;

	m->private = kmalloc(sizeof(struct ctask), GFP_KERNEL);
        if (!m->private) {
                        kfree(file->private_data);
                        return -ENOMEM;
        }
  }

Now, freeing the structure that I did not allocate (file->private_data 
allocated in seq_open()) is not nice. But calling seq_release() from 
->open() method is not nice either (different arguments, namely 'inode'
and also m->buf is NULL at that point, although I believe kfree(NULL) is 
not illegal).

What do you think?

Kind regards
Tigran

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/