Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 19 Sep 2018 13:20:18 +0200
From:   Petr Mladek <pmladek@suse.com>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc:     zhe.he@windriver.com, sergey.senozhatsky@gmail.com,
        rostedt@goodmis.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] printk: Add KBUILD_MODNAME and correct bare use
 of unsigned
Message-ID: <20180919112018.fvncsxc7goffdhpo@pathway.suse.cz>
References: <1537291068-443145-1-git-send-email-zhe.he@windriver.com>
 <1537291068-443145-2-git-send-email-zhe.he@windriver.com>
 <20180919020621.GA390@jagdpanzerIV>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180919020621.GA390@jagdpanzerIV>
User-Agent: NeoMutt/20170421 (1.8.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed 2018-09-19 11:06:21, Sergey Senozhatsky wrote:
> On (09/19/18 01:17), zhe.he@windriver.com wrote:
> > Add KBUILD_MODNAME to make prints more clear.
> 
> No strong opinion. I'm OK with this change.
> 
> > And use 'unsigned int' intead of 'unsigned' according to
> > checkpatch.pl's suggestion.
> 
> I don't think that "unsigned int" is the right thing to use there.
> 
> >  		if (console_seq < log_first_seq) {
> >  			len = sprintf(text, "** %u printk messages dropped **\n",
> > -				      (unsigned)(log_first_seq - console_seq));
> > +				   (unsigned int)(log_first_seq - console_seq));
> 
> Both log_first_seq and console_seq are u64.
> 
> 	log_first_seq - console_seq
> 
> thus, *in theory*, can be larger than "unsigned int". So I'd just avoid cast
> and use an appropriate for u64 %llu sprintf() specifier. Something like below,
> perhaps:
> 
> ---
> 
> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index f73ea9dd6f46..4b8c5832bf14 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -2408,8 +2408,9 @@ void console_unlock(void)
>  		printk_safe_enter_irqsave(flags);
>  		raw_spin_lock(&logbuf_lock);
>  		if (console_seq < log_first_seq) {
> -			len = sprintf(text, "** %u printk messages dropped **\n",
> -				   (unsigned int)(log_first_seq - console_seq));
> +			len = sprintf(text,
> +				      "** %llu printk messages dropped **\n",
> +				      log_first_seq - console_seq);

This looks like a better solution.

Also please, define pr_fmt and fix the casting in separate patches.

Best Regards,
Petr