Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp655293imm; Wed, 19 Sep 2018 04:59:36 -0700 (PDT) X-Google-Smtp-Source: ANB0Vda1+xzzV7iX/71ePvr0eAcX5z17YIvpb1Xxb9ImWw9Lj+XXDCBs2N8BjLKSbTjmB8f5tlk8 X-Received: by 2002:a17:902:be08:: with SMTP id r8-v6mr34529835pls.265.1537358376357; Wed, 19 Sep 2018 04:59:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537358376; cv=none; d=google.com; s=arc-20160816; b=myp00twNr3AC2Xn1rBbUs27byByuK4AuVl3blywRAhOdMORUKCOM/dAq9cZ4PmEdNC IlBtiPAqNuf9FOiLZTwvlDI9TPTYpCmK6cAwupUI9ml9FcmGhGyPs1uOvaKtj8Cu2eV9 A0b8a5VGSguMTJdtCHCy/P2HPs06VcyRvoj4F7LF1e9cYi+bHLlpUtaYdkAlv/Tlv4Ms TlHCL3c/5QOEqac+/H4QICZRnzqzA7LxReFlDTwvYgtFsdRq25cQQIbfqElSe38/HhQc Hr4DEdI310CLqAaZUdYhP0LbyFJ7NR60xOgN1Ha0YCoFk0IdCwqRf3DjkPotxSN5/B9S bN2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=RDhdRXrXL/EFvEoJNHKxSddt13re0IuB5u+SGaZMllg=; b=sBExBuyR4Q58mNcCWP9hrS7GIrXu2zGyUTCZarW8k67t/1RgHek34ouhq5v/ol0Y51 Z937wm5Yw4Jn4pXHqDpFAspavKO5tkr7trX4CBn6YxrLZwwlULbv752z+qLd6CF+Hvqp HFrn/79/NSfOtywntla47icxmOJ3fgUZVpWYXcHZXRLK6pQuW1cw/0tYTRaGLGUiGrg5 4IbejPLN2OOev5bqxjy3mDDNMMANMZ54vGRvRdeVSYH7q2M/qzq1aJRFM2EAvRqLy87z pS9yvHzbsdWx6P1g8Y/gD3pEuhdTOZd3WMR9c1WayVoeE0uBZnAGPRid0QJ8bRwaQHaU Pq6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=mail header.b=iZR2CrMu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l17-v6si21367060pgu.79.2018.09.19.04.59.06; Wed, 19 Sep 2018 04:59:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=mail header.b=iZR2CrMu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731136AbeISR1v (ORCPT + 99 others); Wed, 19 Sep 2018 13:27:51 -0400 Received: from frisell.zx2c4.com ([192.95.5.64]:56099 "EHLO frisell.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726911AbeISR1u (ORCPT ); Wed, 19 Sep 2018 13:27:50 -0400 Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTP id d5708a18; Wed, 19 Sep 2018 11:32:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=mime-version :references:in-reply-to:from:date:message-id:subject:to:cc :content-type; s=mail; bh=UCiDBf3x3lFhkA7rL8SdFe2XMS8=; b=iZR2Cr Muhpu0+mcr9fkJOfgVQhsO9cbb9iVFBcKNfQzNfN8fa26sljQnk1yHgMYF9caLJU VUlHDw0pKoe9HYTx1KnqlHJzhntrOnejWr5H5nS23QF3GcTl5aZArKp4CqUfiEoz OCbJQTEFhhwqVwmw0oU0I/sqZeJC7HiaoVHqYMD56alH0yudAg4Z1C6dQYCbTbAE Y5pj9OqZ+zbvud60c72onAN1OMco4Fq8xLLBVXnobDIw0Sgm2CQMhN60f9BoAu7L aKWNhBp2D3SZMBzZq9/ujWDbHB0y8OgEFO0fbNuEfn7I1Ja9hi+vP6N0zMKRJgAA 9N+jSf1tlw8x1uOQ== Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id f732a200 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO); Wed, 19 Sep 2018 11:32:35 +0000 (UTC) Received: by mail-ot1-f45.google.com with SMTP id j9-v6so5452967otl.2; Wed, 19 Sep 2018 04:50:15 -0700 (PDT) X-Gm-Message-State: APzg51Cye1hNmRGcwlAqwNdDQRypIPg4tQyoJN6505+nUqfot0HOO2bL nEEMNXamc5r4bmoi8LEQcq6ZNz2lSAVlWWut+8w= X-Received: by 2002:a9d:51d0:: with SMTP id d16-v6mr19648183oth.384.1537357815003; Wed, 19 Sep 2018 04:50:15 -0700 (PDT) MIME-Version: 1.0 References: <20180918161646.19105-1-Jason@zx2c4.com> <20180918161646.19105-8-Jason@zx2c4.com> <20180919005054.GC74746@gmail.com> In-Reply-To: From: "Jason A. Donenfeld" Date: Wed, 19 Sep 2018 13:50:03 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH net-next v5 07/20] zinc: Poly1305 generic C implementations and selftest To: Andy Lutomirski Cc: Eric Biggers , LKML , Netdev , Linux Crypto Mailing List , David Miller , Greg Kroah-Hartman , Samuel Neves , Andrew Lutomirski , Jean-Philippe Aumasson Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 19, 2018 at 6:19 AM Andy Lutomirski wrote: > Can you not uglify the code a bit by using normal (non-compound) liberals as described in the response to that email? I can define a bunch of variables, and then string them all together in an array at the end. This is a bit ugly and less maintainable, but would be the best of both worlds.