Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp688046imm; Wed, 19 Sep 2018 05:28:02 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYC56106yqyXMHiDNgDt6EL+GEE25DrwXseEdZzdxHXnsrTkZ4TJ7AUm5gmzFP/X0TuRHJV X-Received: by 2002:a62:a05:: with SMTP id s5-v6mr36447031pfi.147.1537360081985; Wed, 19 Sep 2018 05:28:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537360081; cv=none; d=google.com; s=arc-20160816; b=AXsO1NwhCYSDV1fXxOjQmWUDH7xRmxmX0EgJwWWeoaY0fNnQdCWHn10hsYegbo7nu/ xNt6x3bi0Qok04tb75tA8errHrqj2bfgi2WfeeXkI7DvHG48FsR+dIhB9d+HriF/0fb3 9RxWW1LFVK0rVdU6bwv9NqeodrFIybI31lfbIlbv9rCoilSxKsiUVUKuaGrnF7Uz89tV kZI61TQsotXkvZxCzFVBMQS5OGIqHm+lPPgrPBaWhZhNx62DekfbVqxj3myBzQWml22K FHkJPtLHDSkREyCLMhOWNYGv1rDmt2F8bnI5nqPbANcrSMOpgktchFmeoG3sw6+763A0 1sbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=bg4zHIOuZQxeeTGvXWzp9NAQBhRaaPFzFD2fJXjlJFc=; b=Km8sleGcZeegb+yfPVlnhRhYtprIOwd++ZW4NLKtZ4IorY5jI3vWuCkRBDPc2/cGSz I0Kgp42pJTNOhYHa4V12LDoxZpleEFqczHLma7Aern2ElQh9zvCtNutNdmHosBvWEfOw eTP6uEGBQNy4glgUAlDQccMA5VnNdxoYV/+PfAWwO+tHQjn9IrdgixXdYvS2d0vPwN+R 9WyAnjCC1Z0unCq6PJ1tfv0C8feIL0oz2itswK+tLgDCLwT1aEiewNWV422hRZSN7HbF roVfxyj2lTsbhOVWeq6JKmMp2bjaGVAtcf7mIQRZpN+tMUTfE4ZlIfpJ2I+oNh10hbDS FB9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=mail header.b=04ZyHqxW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s9-v6si19754895pgk.384.2018.09.19.05.27.43; Wed, 19 Sep 2018 05:28:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=mail header.b=04ZyHqxW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731442AbeISSEf (ORCPT + 99 others); Wed, 19 Sep 2018 14:04:35 -0400 Received: from frisell.zx2c4.com ([192.95.5.64]:41421 "EHLO frisell.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727772AbeISSEe (ORCPT ); Wed, 19 Sep 2018 14:04:34 -0400 Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTP id e6af9933; Wed, 19 Sep 2018 12:09:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=mime-version :references:in-reply-to:from:date:message-id:subject:to:cc :content-type; s=mail; bh=4qfqBAAM8rP4GnrmCYyNp/gpMrc=; b=04ZyHq xW3lTQhH0YL3Cx43+kCtG8/fdUfc3DUo+kuaj/sgxotc/VJkXTD3l8CwNP23QT/s hK3DXv4u6cY3S3QVahiPLW/3YJuqlFF0RtSkEF+SRI4sMkHBjPyPRTrEojsi3kLN GnbT2vnCFzBHCAXM6P95INmhN9QNy6rtMBpH8ZNVd1rJJb3m6ukZNxq9qYdSaeeU AWjJ6LLrJ/r2WxB9GMC10H7vxBvE2Zt5E9NQXcuQvxEMgpyziOdKRMsBiU1N/GOq jHIoY/RrV359l+RiM6RZ5YveXRTVjngH5wbHgQKJj9rKUfjPFDxYBmyEKvo2lyRd 2kl3jtSoV/lAfi6Q== Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 3540a8f9 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO); Wed, 19 Sep 2018 12:09:09 +0000 (UTC) Received: by mail-ot1-f44.google.com with SMTP id v44-v6so5504956ote.13; Wed, 19 Sep 2018 05:26:50 -0700 (PDT) X-Gm-Message-State: APzg51DUczaAxS5IgfmihhjAt3oz7mALbyvY8A8TDlbe0zBSy8aQJ4x7 FMbwtHi4UMJ2X/3K+9F7Ufp9B9IMxV0WXWeTBSI= X-Received: by 2002:a9d:522d:: with SMTP id e45-v6mr17627413oth.250.1537360009775; Wed, 19 Sep 2018 05:26:49 -0700 (PDT) MIME-Version: 1.0 References: <20180918161646.19105-1-Jason@zx2c4.com> <20180918161646.19105-8-Jason@zx2c4.com> <20180919005054.GC74746@gmail.com> In-Reply-To: From: "Jason A. Donenfeld" Date: Wed, 19 Sep 2018 14:26:38 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH net-next v5 07/20] zinc: Poly1305 generic C implementations and selftest To: Andy Lutomirski Cc: Eric Biggers , LKML , Netdev , Linux Crypto Mailing List , David Miller , Greg Kroah-Hartman , Samuel Neves , Andrew Lutomirski , Jean-Philippe Aumasson Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 19, 2018 at 1:50 PM Jason A. Donenfeld wrote: > > On Wed, Sep 19, 2018 at 6:19 AM Andy Lutomirski wrote: > > Can you not uglify the code a bit by using normal (non-compound) liberals as described in the response to that email? > > I can define a bunch of variables, and then string them all together > in an array at the end. This is a bit ugly and less maintainable, but > would be the best of both worlds. Alright, I wrote a little program to do this for me in a way that actually doesn't look half bad. Thanks for suggesting. Jason