Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp697951imm; Wed, 19 Sep 2018 05:37:19 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZ1SYLGeI+3yWWjvS/P88ZFvNCR3IECISDUXx3Yxzb/Kom0Fihy+FM8blM7otnOIxjyNL8p X-Received: by 2002:a63:6746:: with SMTP id b67-v6mr32547223pgc.330.1537360639902; Wed, 19 Sep 2018 05:37:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537360639; cv=none; d=google.com; s=arc-20160816; b=y9tTufm9K9WMeU2ShdOVti1vHVpVvuSJBzIsO1j1VSvbIcdJozYhZPHkGqZXFVpWLY VpNszHgoCr8zWvkl9XQaI4T9sZuK6W+fKyNV689z4VApwaxgRQU+ilI8yWrzs5cmUda2 JPs7Auwp2AG83hw0xeD8iaPxrV6OLvleModyUiKc6ge3GnqwoNA62M4nhto5OtkKPq+l mNqyVznb7rB1v7Me6k9Eve17N3MBb9oEkK3zUaVpxX79pO8/xMDJRXahjRPqbZUSkvTI Pg/KazdjK7qgiNEhM5newfRf0NS9EVi4otZ0pIABeRB4QEi4vLU/AC2HKEqS74mXVNXY qC6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=jZGsVNcQdXgMG4CdMFByJK1CsAcAxunt1fcn7ssIes4=; b=BGPZdVbM4CyoB9cLMjQ3owvsPn9i/Z2EBQrwzmmUoufuwomPpdjrhepf3pBVe7Co41 S1mCfGf2ynKkX603yO2ozZnIykcGdcmVr5OzOmUA/ek49LTPKg9fMjBgK2Kzqu8Crt0c /kvLg/gu1tVf70WlEQQBpD6kKLbmY7jpXtSTa9VQQ5thOfO9W1D2+zDowO5sV7hqAHPr Nw7fKxat3UZh8ZYQeFK7CI8fJYj53PFXK2Wct+9zJ5AVVHNt3eZJUGnoYxsXY29XshCc iODLmrz9Bv2+1NnKhOp4pjcbXsfYpfty9zC6qFhw/b64NpLRgcUmVuAYGL5ljgHw4SXN 6+uw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a17-v6si21145562pgb.369.2018.09.19.05.37.04; Wed, 19 Sep 2018 05:37:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731989AbeISSOa (ORCPT + 99 others); Wed, 19 Sep 2018 14:14:30 -0400 Received: from inva021.nxp.com ([92.121.34.21]:33226 "EHLO inva021.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731930AbeISSO2 (ORCPT ); Wed, 19 Sep 2018 14:14:28 -0400 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 4A3252001FC; Wed, 19 Sep 2018 14:36:43 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 3E18E2001FA; Wed, 19 Sep 2018 14:36:43 +0200 (CEST) Received: from fsr-ub1864-101.ea.freescale.net (fsr-ub1864-101.ea.freescale.net [10.171.82.97]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id A8E5020618; Wed, 19 Sep 2018 14:36:41 +0200 (CEST) From: laurentiu.tudor@nxp.com To: devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: roy.pledge@nxp.com, madalin.bucur@nxp.com, davem@davemloft.net, shawnguo@kernel.org, leoyang.li@nxp.com, Laurentiu Tudor Subject: [PATCH 15/21] dpaa_eth: fix SG frame cleanup Date: Wed, 19 Sep 2018 15:36:07 +0300 Message-Id: <20180919123613.15092-16-laurentiu.tudor@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180919123613.15092-1-laurentiu.tudor@nxp.com> References: <20180919123613.15092-1-laurentiu.tudor@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Laurentiu Tudor Fix issue with the entry indexing in the sg frame cleanup code being off-by-1. This problem showed up when doing some basic iperf tests and manifested in traffic coming to a halt. Signed-off-by: Laurentiu Tudor --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index 8db861f281a0..605f06f0def8 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c @@ -1663,7 +1663,7 @@ static struct sk_buff *dpaa_cleanup_tx_fd(const struct dpaa_priv *priv, qm_sg_entry_get_len(&sgt[0]), dma_dir); /* remaining pages were mapped with skb_frag_dma_map() */ - for (i = 1; i < nr_frags; i++) { + for (i = 1; i <= nr_frags; i++) { WARN_ON(qm_sg_entry_is_ext(&sgt[i])); dma_unmap_page(dev, qm_sg_addr(&sgt[i]), -- 2.17.1