Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp701509imm; Wed, 19 Sep 2018 05:40:51 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdaf6/ItKA2mKlZCjhkn4nrHDcTPcRispUkbsrd+czWgMjjFsXDQAmx036ZG9utDikt8StQp X-Received: by 2002:a63:6881:: with SMTP id d123-v6mr32001240pgc.298.1537360851734; Wed, 19 Sep 2018 05:40:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537360851; cv=none; d=google.com; s=arc-20160816; b=1GuBwu4kpWDZ74MHwuqH2RyOaNfUxgDRJ+uGv8Ffjw4jR3OrKhrYPQeijEiJtu4ltm +rP87FHubcDEbN7AeySsum3c4cpx4xWofcp8KcFQMLzRvirOnAZSUtpKxSb3ABQvQ+3X QUCWNYWjEeRg64kzRdIkOLcCaTiEiunhPdIj8yvdaAovE/fgAyFwulDe8+3QmKbimF5C XCgEDi5O/si3VhKp320GdqoPvAK5EvSUNIVaqtIO9jq1uPBlszD1ZOAekuDQ8GI/Uvd4 gR170kF4/9/atbTt4nod5aaVM14NWMW3T5A8PJNLycy3DUPKRtWcbljIq9yW3v8r383b mC9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=VcFVaYbLHlJPXlIiGUFQIHST7L1Uc6yUvYwcUj4mDe0=; b=PZNqH2UHYMkUOHyaoPDZ6a9ZHPrAkJ7DF22MWHDxESLyH2jc4ij50F7tNDvdf8puTG tS2tE+KMp4xAOzA4aZaIajr4quuuRcJchSUrBWeNE35l1+R8RaD6yF6D6Ecfc6Itk6Cb szPlfSm/4lsPTrcx8/l41CCaLuxQ8YhdOJgweTz2HEXNp86J6rDqyf0N/rtNXD382Lcv Qr8QQNtleauW212OcIBXryCkyoWxOYn5mcxQIA/WwuO9jOJY/vgfDyhKmtrHgBUfPveM mDmkJV2MIb6I1BFEeK8mBf3JNoHKpWPry2H/swSM6rpjmJcZLCg5ubZhlWTh2jbG9/ik DX8w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bc6-v6si20692798plb.115.2018.09.19.05.40.36; Wed, 19 Sep 2018 05:40:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731849AbeISSSC (ORCPT + 99 others); Wed, 19 Sep 2018 14:18:02 -0400 Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:59820 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728192AbeISSSC (ORCPT ); Wed, 19 Sep 2018 14:18:02 -0400 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.89) (envelope-from ) id 1g2bm1-0002um-Io; Wed, 19 Sep 2018 14:40:05 +0200 Date: Wed, 19 Sep 2018 14:40:05 +0200 From: Florian Westphal To: zhong jiang Cc: davem@davemloft.net, kadlec@blackhole.kfki.hu, pablo@netfilter.org, fw@strlen.de, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: conntrack: get rid of double sizeof Message-ID: <20180919124005.eidjr2qtryrongae@breakpoint.cc> References: <1537359671-53720-1-git-send-email-zhongjiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1537359671-53720-1-git-send-email-zhongjiang@huawei.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org zhong jiang wrote: > sizeof(sizeof()) is quite strange and does not seem to be what > is wanted here. Fixes: 39215846740a9f ("netfilter: conntrack: remove nlattr_size pointer from l4proto trackers") Acked-by: Florian Westphal