Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp814899imm; Wed, 19 Sep 2018 07:20:58 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZ4778RVdzMm9CBZcY2dtIX886SkCwa7FoXy/vii1N+Uphx3jxtdjhWhVvupVCbx1p0xogh X-Received: by 2002:a17:902:a613:: with SMTP id u19-v6mr35011421plq.234.1537366858230; Wed, 19 Sep 2018 07:20:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537366858; cv=none; d=google.com; s=arc-20160816; b=zQytypJedIaWf83crlnWzm2Ft6/n7ykMX2aQL5/cXSavrF85b6C4V1cmtWr2XQuMyP lUccSrAkgK6BsgzKgB4SGOyhQNl4Dk1FnHaBcPb24gkNH81gwTH/6zMBGM3c/mtfo9Bg uRqH6mTFJf7XbZtH0o1MWQJGpuuqlKnH8tpixA9rg2wAWU6zaXhO6PalxiQ99ugE3CCY nMFH4Xx4oMwU0cnmzy//zf2XZpn5QPAnxt7EEI8FhX0YCKLFtvsATrhkE1bAcAMy0VLc 5ELPXiJdQBC/3uDhaWY5/OByN3EmQ3kk9mdH4UjeQewheLvU4ua9lqFAb8RkYlCCY+zi jO8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=rwgZzVyZQ2IgMqH2eFrc3YDGe9DVqPJuBPJQignJc7k=; b=Y9MPHIzLiDNYs+EvWzZt5FOmeQ/80E90w8eiSD3oydIFf7k1a6T98xQxzESO7NGspq UZ7um9sb9dJTIZPS9rH0aDeGjJWulX4jJh3zv5Q+1NZXKilQ0oglSjzmjy7xAlWhS3r8 NEC7gre5GG8HGyEfjK+isvYy+SfGBPCibOMZSOt3iU8LYk9MzPWF89JBicRA2SGqz7ma OiJKcPI1PMBSCEo+Ecs47FUWgebZjb8X32EfM/6PKOfb2fXP6+XclhLDtYhPu0p/WqNI lRw7/EZzNAwyUcubJouKPo+xG8xWtrwJjU0TZC+B/7qskFJYCg0tVdCdaNCUSaakxtKl kk7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y8-v6si22829348pfk.75.2018.09.19.07.20.41; Wed, 19 Sep 2018 07:20:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731932AbeISTmh (ORCPT + 99 others); Wed, 19 Sep 2018 15:42:37 -0400 Received: from mga09.intel.com ([134.134.136.24]:61059 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731857AbeISTmh (ORCPT ); Wed, 19 Sep 2018 15:42:37 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Sep 2018 07:04:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,394,1531810800"; d="scan'208";a="258578231" Received: from pqueiros-mobl.ger.corp.intel.com (HELO localhost) ([10.249.37.13]) by orsmga005.jf.intel.com with ESMTP; 19 Sep 2018 07:04:26 -0700 Date: Wed, 19 Sep 2018 17:04:25 +0300 From: Jarkko Sakkinen To: Tomas Winkler Cc: Jason Gunthorpe , Alexander Usyskin , Tadeusz Struk , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 05/20] tpm: factor out tpm_get_timeouts Message-ID: <20180919140425.GH26571@linux.intel.com> References: <20180918093459.19165-1-tomas.winkler@intel.com> <20180918093459.19165-6-tomas.winkler@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180918093459.19165-6-tomas.winkler@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 18, 2018 at 12:34:44PM +0300, Tomas Winkler wrote: > Factor out tpm_get_timeouts into tpm2_get_timeouts > and tpm1_get_timeouts. Function names missing parentheses. Should be there for clarity when used in a sentence. Otherwise, the commit looks fine. Tested-by: Jarkko Sakkinen /Jarkko