Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp968487imm; Wed, 19 Sep 2018 09:45:06 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYb52juXz2DnWUwj5C1G/vgy9/xItig9IWZUydjmk0Fc/du0Q/9lLgIndLl6ixgwPiv0sAL X-Received: by 2002:a62:54c7:: with SMTP id i190-v6mr36819985pfb.155.1537375506450; Wed, 19 Sep 2018 09:45:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537375506; cv=none; d=google.com; s=arc-20160816; b=afp0442ykiE3ADDMn8qNhkAlRzQXMnohq73b0crnrUXaBp3SoYB04vGUbVn0j6qUke GpzGNCAsBuxxmgZG/FHomvFJbXrL4C8MMYcnT/Jhepg52tGRahAIaX3EerxsfAV7GeLU 1lyGNB9LubWO88xW/JYfMrATrTCVWqV8eTR8FC/x0gQ2TkrkDX0ZN2QJOX6lxO+A83OL 29wm2NuFaXUPtF0PfqSp+6sdrrNvFThQOXhtTyeQQpDE71cZe8m/5fFzlIPx58ixWzus n060qwGZy+M7zTxx6cyXCu9X7rfgQ+ADdZBckLACqlR5Adj3ox+stVra1WnFhfCFEXAy nVBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=emUEFn0OcajAlFY/h/sddojpuUAUq45BqeIFhvEdgpw=; b=lQaQF8cbiIIDDfEG2xiH6sJfp0/zRYnWpcB5p9KqkkBMErL+vaTAZvoDAhj9Kew6Ys xfa9vc0ImDQGHHWD9M5Pg7XZFtDkdMPHpc9GHnJzv6g8KLsqFiDK65p8I7VqOjd1wNeV EAwmsqcG/UJJPQWCbpOuIPqnQMsXMSXyjvo3lRRNGh3gsBqq/4cl+QlBevYkrzurpkBQ uJaaKcxgCkN56dPy8s96d9rh6uDs0o+DuGSKGwve8qRPya5rOAOvQdDSTZiM7KcsO1Qz D0gPP09d1+09WhU/UV30E7D9DHCS12wrBe29ze+6vuj9zRBM5IB0FLM5AQo9j9RAdQcW jCJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=bW7SfUwZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v1-v6si22624595plb.387.2018.09.19.09.44.43; Wed, 19 Sep 2018 09:45:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=bW7SfUwZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732084AbeISVwT (ORCPT + 99 others); Wed, 19 Sep 2018 17:52:19 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:45811 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726908AbeISVwT (ORCPT ); Wed, 19 Sep 2018 17:52:19 -0400 Received: by mail-pf1-f196.google.com with SMTP id i26-v6so2923295pfo.12 for ; Wed, 19 Sep 2018 09:13:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=emUEFn0OcajAlFY/h/sddojpuUAUq45BqeIFhvEdgpw=; b=bW7SfUwZYX3WdkJY+AUGos1TWKZoPFQoGDcS45xzGlc/2amy6IkhzUWMJojAIyG0FJ eywgOq7EQcv7j9RqnqnW5VS4fkoFRX2LlyVlGhnheEw1ZwVB2g9Tig181qQQd72AKwsQ k61JFXqNsqtbLUfcva6GHx9akvJSYIqs3XMkHpQmtyfukwohNpGPwLCNLlkK2kvdLyXa nps+9bp8d9aOhhR+WrPz8FV/3wLTl7iCDm5bCBnFMZOsTeEnYgMHed27igTGfA0rtfNe vzYcqxogIUvrTH9MFW+QmNI9K3XXDzUK6WAdI4WGLmJoZms0e/bP5fDLlVEtyoVdqWVL 3Wug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=emUEFn0OcajAlFY/h/sddojpuUAUq45BqeIFhvEdgpw=; b=McgXfNSm18Zrus7Sd4Kfdm8RWvRwLjd4ecMtOixPISq8Xrzhyq4R+E1gasFj7nWrym 97Wj6GHlz3k2SCzuAavCz6AtFcgK5hkxS38oOvrwXwDU68wCZtcMJ7zfv+SNJhWYNsgU e1ZC7SfImlor6VM0hituUPxmGqdjFy5DE9LcOQbY+lZ5dME4lXLFbbjcNFSioTHOGbTG 306L/eZTz0X/p0Cq9vl1PhGR71s98KoR8+PIx0KmKvTIyaqSHg07bxuUEd52Mw3yUGhj qRKy0Rklt4S/LMv6WUJwEcLYd87vTCcXngbnkliCiCJ9Cz19FlGIKCFIBay1P0UWNlaP YJ4Q== X-Gm-Message-State: APzg51BZQ/pEEI7fyDgpNuN9hddYCFrzWMywuSS2lucf86fl1dEOpXAh IJ3NQBn9W4BMZcSWEhocE7uflQ== X-Received: by 2002:a63:6385:: with SMTP id x127-v6mr33447667pgb.413.1537373622917; Wed, 19 Sep 2018 09:13:42 -0700 (PDT) Received: from ziepe.ca (S010614cc2056d97f.ed.shawcable.net. [174.3.196.123]) by smtp.gmail.com with ESMTPSA id p19-v6sm34260287pgk.28.2018.09.19.09.13.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Sep 2018 09:13:41 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1g2f6j-0002Zp-3q; Wed, 19 Sep 2018 10:13:41 -0600 Date: Wed, 19 Sep 2018 10:13:41 -0600 From: Jason Gunthorpe To: =?utf-8?B?SMOla29u?= Bugge Cc: Doug Ledford , faisal.latif@intel.com, shiraz.saleem@intel.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] RDMA/i40iw: Fix incorrect iterator type Message-ID: <20180919161341.GB9867@ziepe.ca> References: <20180917140707.1253738-1-Haakon.Bugge@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180917140707.1253738-1-Haakon.Bugge@oracle.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 17, 2018 at 04:07:07PM +0200, Håkon Bugge wrote: > Commit f27b4746f378 ("i40iw: add connection management code") uses an > incorrect rcu iterator, whilst holding the rtnl_lock. Since the > critical region invokes i40iw_manage_qhash(), which is a sleeping > function, the rcu locking and traversal cannot be used. > > Signed-off-by: Håkon Bugge > --- > drivers/infiniband/hw/i40iw/i40iw_cm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to for-next, thanks Jason