Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp994011imm; Wed, 19 Sep 2018 10:09:50 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbEoU+8pHHHEe0qF1jaHdj5ODSg1Te/OrVTeUB6nVtokmoS4VxW5U7m/t+o433b7FiWwLb9 X-Received: by 2002:a63:ce43:: with SMTP id r3-v6mr33953645pgi.439.1537376990489; Wed, 19 Sep 2018 10:09:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537376990; cv=none; d=google.com; s=arc-20160816; b=RAOGGqW/hEmspdOB2+ivLBCZt113SCUG155sR3ooxBrkKwria9ZZsJIRvUfMkqxe/A XSPzd92E94/aPult/Lw6OZ2Lg6iHTepHMOLDLU6eaIJ2shtFZ/WUCBMSgokgoTjBi9ML dk9qiIs/axCqX7nQEqCtmqSs5yEHCDHIem3xFyBXt2wahMKsYzjI8N5RBU6qx9ErWRVV b9hgrOue9vrD6G1lxJuaJGNguYR86heic9c9adpBXeYZAkfXQJ5x39MwttIgswz8RbRY RMrvSizBj9RVDOBm/qnsG5OWsJhyxc3qsYignMKYSRkvh0BYLw+nMeDJgm5s/ij7dgx6 hURA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=kDjkVH+3uVmPboIlqprt7i56mul4/eEGMAuNNejkuLk=; b=xJBoKKN/QOvqVVCI1Quz0M2B3ZJBpc3AAcaDDZnA/KD9gpL6hE/qT/wdzRCZNg/Pjx NuBrsajueuQB7dsx1wzCwXThzyZ1JhxWUPUhCl2KN35xddIlch/xEJ0zZ0dPy6wZJtxX EsYJYmpfixthQHz+QSFFH3oyO8pDCfB3jS3AlG1zyeqzCZWgDBj/W4DvSAJ41mW2AHxr OgM4xVzXWDPh7oiJNkm9Rqvmv9na1Gi+IncQP/AUvDWi4bJxKpId8yia+Gcw0DKXM7jb cfiX5U5gBkEl8OjaAdSl1sB3LVzQylaigeHdb9Iqj+VjIWW9p+mo8s8xVYqw6zpWObPs KViw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a8-v6si23847831pln.392.2018.09.19.10.09.22; Wed, 19 Sep 2018 10:09:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732636AbeISWpW (ORCPT + 99 others); Wed, 19 Sep 2018 18:45:22 -0400 Received: from mail.bootlin.com ([62.4.15.54]:57224 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731460AbeISWpW (ORCPT ); Wed, 19 Sep 2018 18:45:22 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 5FD5A20798; Wed, 19 Sep 2018 19:06:31 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [15.65.243.10]) by mail.bootlin.com (Postfix) with ESMTPSA id 8AE0720719; Wed, 19 Sep 2018 19:06:20 +0200 (CEST) Date: Wed, 19 Sep 2018 19:06:18 +0200 From: Alexandre Belloni To: Giulio Benetti Cc: a.zummo@towertech.it, andy.shevchenko@gmail.com, robh@kernel.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 4/4] rtc: ds1307: add frequency_test_enable sysfs attribute to check tick on m41txx Message-ID: <20180919170618.GC2479@piout.net> References: <20180725172605.108040-1-giulio.benetti@micronovasrl.com> <20180725172605.108040-4-giulio.benetti@micronovasrl.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180725172605.108040-4-giulio.benetti@micronovasrl.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/07/2018 19:26:05+0200, Giulio Benetti wrote: > On m41txx you can enable open-drain OUT pin to check if offset is ok. > Enabling OUT pin with frequency_test_enable attribute, OUT pin will tick > 512 times faster than 1s tick base. > > Enable or Disable FT bit on CONTROL register if freq_test is 1 or 0. > > Signed-off-by: Giulio Benetti > --- > V10 => V11: > * kstrtobool(): check error if (ret) avoiding checking specific error. > > drivers/rtc/rtc-ds1307.c | 94 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 94 insertions(+) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com