Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 20 Sep 2018 02:09:01 +0200
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     kbuild test robot <fengguang.wu@intel.com>
Cc:     "Angus Ainslie (Purism)" <angus@akkea.ca>, kbuild-all@01.org,
        Krzysztof Kozlowski <krzk@kernel.org>,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: bq25890_charger: fix semicolon.cocci
 warnings
Message-ID: <20180920000901.45mhrxwhqfuzxjp7@earth.universe>
References: <201809171037.IF98pmY7%fengguang.wu@intel.com>
 <20180917022320.GA43295@lkp-ib04.lkp.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="xerj56hofwpl3dfm"
Content-Disposition: inline
In-Reply-To: <20180917022320.GA43295@lkp-ib04.lkp.intel.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--xerj56hofwpl3dfm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Sep 17, 2018 at 10:23:20AM +0800, kbuild test robot wrote:
> From: kbuild test robot <fengguang.wu@intel.com>
>=20
> drivers/power/supply/bq25890_charger.c:614:2-3: Unneeded semicolon
> drivers/power/supply/bq25890_charger.c:621:2-3: Unneeded semicolon
> drivers/power/supply/bq25890_charger.c:630:3-4: Unneeded semicolon
> drivers/power/supply/bq25890_charger.c:638:2-3: Unneeded semicolon
> drivers/power/supply/bq25890_charger.c:644:2-3: Unneeded semicolon
>=20
>=20
>  Remove unneeded semicolon.
>=20
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>=20
> Fixes: 9d9ae3414d1b ("power: supply: bq25890_charger: Add debugging outpu=
t of failed initialization")
> CC: Angus Ainslie (Purism) <angus@akkea.ca>
> Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
> ---

Thanks, queued.

-- Sebastian

>=20
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-s=
upply.git for-next
> head:   cb90a2c6f77fe9b43d1e3f759bb2f13fe7fa1811
> commit: 9d9ae3414d1bb655d8db7079e56b0f51e7cd07f0 [4/13] power: supply: bq=
25890_charger: Add debugging output of failed initialization
>=20
>  bq25890_charger.c |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>=20
> --- a/drivers/power/supply/bq25890_charger.c
> +++ b/drivers/power/supply/bq25890_charger.c
> @@ -611,14 +611,14 @@ static int bq25890_hw_init(struct bq2589
>  	if (ret < 0) {
>  		dev_dbg(bq->dev, "Reset failed %d\n", ret);
>  		return ret;
> -	};
> +	}
> =20
>  	/* disable watchdog */
>  	ret =3D bq25890_field_write(bq, F_WD, 0);
>  	if (ret < 0) {
>  		dev_dbg(bq->dev, "Disabling watchdog failed %d\n", ret);
>  		return ret;
> -	};
> +	}
> =20
>  	/* initialize currents/voltages and other parameters */
>  	for (i =3D 0; i < ARRAY_SIZE(init_data); i++) {
> @@ -627,7 +627,7 @@ static int bq25890_hw_init(struct bq2589
>  		if (ret < 0) {
>  			dev_dbg(bq->dev, "Writing init data failed %d\n", ret);
>  			return ret;
> -		};
> +		}
>  	}
> =20
>  	/* Configure ADC for continuous conversions. This does not enable it. */
> @@ -635,13 +635,13 @@ static int bq25890_hw_init(struct bq2589
>  	if (ret < 0) {
>  		dev_dbg(bq->dev, "Config ADC failed %d\n", ret);
>  		return ret;
> -	};
> +	}
> =20
>  	ret =3D bq25890_get_chip_state(bq, &state);
>  	if (ret < 0) {
>  		dev_dbg(bq->dev, "Get state failed %d\n", ret);
>  		return ret;
> -	};
> +	}
> =20
>  	mutex_lock(&bq->lock);
>  	bq->state =3D state;

--xerj56hofwpl3dfm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAlui5RoACgkQ2O7X88g7
+pqlRw//XUNf6eElbVHGqYwMCeFrc2TWGADGEodv8TSPKU2GTEhfKEWVawCZfKBj
l+E/Sz/W/msVfI90Gyvu7XJc8X2X1p3JgdOTJcPnxZrbyaEXnZN9gblZ9wt87zdo
Kodv1rvzc4TbWZCWavwXektxQvjPKMgUm1vs/41iZYtqhNUtN4VhtIShwGdqY4jn
gCjsYinkTTwuHwArlPNh9C67vWJBxk4XaxBBPU9ZO1MeHQ54mX/miQDagKRXYggS
5Ri275G3IlDKcTJM3lRv93UOoDdWFhiqTWkNGnm4vMUgCgBPrQ9jIZdMs8wayHit
699IcmEHQuRyppZ30TgvzWOcOVZ9TPAH+W+sveRs3j1tJKkzZKqayQunt939SSoo
Yc6iFJXSq2WuE+aYQBlRZ3L77+lDglt0WJTwSgQkGEiEZhDiKpC86bkiB8xh1DKz
n2vvGUsD+Hgoc/G4+FqTZwWFbtweaOGDpMwI8JwQyI1xzcIUCG8AbrMYGq75+gYr
ZJQk6glNki7ehvB/Smz5vffHcpKhi0FyVf3+nzBE1l6ox+QgaDhR/oSQ4STAiB3s
1p2RtPjwR4apSjnM/9lU5I2mPZFaSjgLY0dNNtvBuQmCrWTH8O1BiHW/WRs6ibYT
tFqvfTHN5CSpgRcrRVwfB1WTOebTiBlmoXLmyAdVFJau8YQthPI=
=SHah
-----END PGP SIGNATURE-----

--xerj56hofwpl3dfm--