Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180919234721.16042-1-tpiepho@impinj.com>
In-Reply-To: <20180919234721.16042-1-tpiepho@impinj.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Thu, 20 Sep 2018 08:48:36 +0200
Message-ID: <CAMuHMdVMbjkvEXex_Z8ELPUo8hVZucFBCd2Wy4ENpiqEaLES_w@mail.gmail.com>
Subject: Re: [PATCH] ARM: amba: Fix leak of driver_override attribute value
To:     Trent Piepho <tpiepho@impinj.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        Todd Kjos <tkjos@google.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Greg KH <gregkh@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Sep 20, 2018 at 1:48 AM Trent Piepho <tpiepho@impinj.com> wrote:
> If driver_override was set when a device was released the string would
> not be kfree'ed in amba_device_release and thus leaked when the amba
> device was freed.
>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Todd Kjos <tkjos@google.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Trent Piepho <tpiepho@impinj.com>

Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Fixes: 3cf385713460eb2b ("ARM: 8256/1: driver coamba: add device
binding path 'driver_override'")
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds